fix: searchInMethods and searchInClasses - #58
Merged
Merged
Conversation
Contributor
|
不过该 PR 引入了 opcode 允许使用 -1 作为通配的逻辑，并将原有的 opcode Contain 的 KMP 匹配替换成朴素实现，导致在极端情况下匹配复杂度会从 O(n+m) 退化成 O(n*m)。 我认为本 PR 应该保持为纯粹的 bugfix，只修复已有行为：
opcode 通配符可以考虑支持，但是应拆到独立 PR 中讨论 API 及实现 |
EndWith was anchored to the first occurrence found by kmp::FindIndex, so a pattern that also appears earlier in the sequence failed to match the tail. Compare the tail directly instead.
Author
|
已按建议调整 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.