Repository navigation
ci: fetch AuraFace for the nightly golden tests - #464
Merged
Merged
Conversation
#460 added the `auraface` golden family together with a committed reference embedding, so `LRG_REQUIRE_GOLDENS=all` now demands auraface_glintr100.onnx — but golden-tests-full.yml never downloaded it, and the nightly went red (auraface_matches_insightface_reference: assets missing). AuraFace is not a release asset; the server pulls it from Hugging Face at a pinned commit. The workflow now does the same, reading repo, revision, file and sha256 from `auraface_source` in face_goldens.json (the source the reference was made from) and failing on a hash mismatch. Docs list `auraface` among the LRG_REQUIRE_GOLDENS family names (CLAUDE.md, AGENTS.md, CONTRIBUTING.md, server-rs/README.md, Dev-Server-README.md). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HaMMvs5Zqtm9RhCkDHer9F
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HaMMvs5Zqtm9RhCkDHer9F
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The nightly Golden tests (all model assets) run failed (job):
#460 added the
aurafacegolden family and committed its reference embedding toface_goldens.json, soLRG_REQUIRE_GOLDENS=allnow requires the AuraFace model.golden-tests-full.ymlnever downloaded it. (YuNet is present; the message lists both files because the test checks for both.)What
golden-tests-full.yml: downloadglintr100.onnxfrom Hugging Face asauraface_glintr100.onnx. AuraFace isn't a release asset, and the server fetches it the same way (routes/face_recognizer.rs). The step takes repo, revision, file and sha256 fromauraface_sourceinface_goldens.json, which records the exact file the reference came from. It checks the hash withsha256sum -c, so a moved or changed upstream file fails the job instead of producing a confusing numeric mismatch.aurafaceto theLRG_REQUIRE_GOLDENSfamily names in CLAUDE.md, AGENTS.md, CONTRIBUTING.md,server-rs/README.mdanddocs/wiki/Dev-Server-README.md.PR CI (
server-rs-tests.yml,LRG_REQUIRE_GOLDENS=face) is unchanged.aurafaceis a separate family, so PRs still skip it.Testing
jqextraction givesfal/AuraFace-v1 af6d057c… glintr100.onnx a7933ea5….scripts/check-docs.pypasses.workflow_dispatch) on this branch will check it end to end.Generated by Claude Code