Repository navigation
deps: bump rustls to 0.23.46 for four security advisories - #461
Merged
Merged
Conversation
Fixes Dependabot alerts #79-#82, all in rustls < 0.23.46, which the backend pulls in only through reqwest/hyper-rustls/tokio-rustls: - GHSA-c8m5-c952-6cm4 (medium): Debug formatting of a session exposes TLS master secrets and resumption PSKs - GHSA-h2v8-394m-p7vv (low): Brotli certificate decompression can allocate up to 1 GiB before authentication - GHSA-w44r-93j7-qv28 (low): an unauthenticated ServerHello poisons the key-exchange record, so later ClientHellos send only X25519 - GHSA-vp88-798v-h67f (low): ECH rejection can expose buffered data to the outer server Lockfile change is rustls alone; cargo update also re-resolved tempfile's getrandom (0.4.3 -> 0.3.4), which was dropped as unrelated. Builds with --locked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HaMMvuCsggAAAZqFC3FdDX
#460 added the paragraph on the upsert write ceiling (UPSERT_CHUNK_BYTES) to server-rs/README.md without rerunning scripts/build-wiki-pages.sh, so check-docs.py has failed on main since. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HaMMvuCsggAAAZqFC3FdDX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the four open Dependabot alerts (#79–#82). All of them are in
rustls< 0.23.46, which the backend uses only as an HTTPS client, throughreqwest→hyper-rustls/tokio-rustls. None of our code calls it directly.Change
server-rs/Cargo.lockonly: therustlsversion and checksum, 0.23.45 → 0.23.46.cargo update -p rustlsalso movedtempfile'sgetrandomdependency from 0.4.3 to 0.3.4, which has nothing to do with these alerts. I took that out. The lockfile with only therustlslines changed still builds with--locked.Checks
cargo clippy --workspace --all-targets: no warningscargo test --workspace --locked: 925 passed, 0 failedAlso: docs-check on main
docs-checkhas failed on main since #460, which added a paragraph toserver-rs/README.md(theUPSERT_CHUNK_BYTESwrite ceiling) without regenerating its wiki copy. The second commit regeneratesdocs/wiki/Dev-Server-README.mdwithscripts/build-wiki-pages.sh. No wiki page documents the lockfile itself.🤖 Generated with Claude Code
https://claude.ai/code/session_01HaMMvuCsggAAAZqFC3FdDX