Skip to content

Don't cache the version number string within VersionNumber #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JesseTG wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't cache the version number string within VersionNumber #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 15 additions & 23 deletions Assets/Version/Version.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
using System;
using System.Collections.Generic;
using System.ComponentModel;
using UnityEngine;
using UnityEngine.UIElements;

namespace LMS.Version
{
Expand Down Expand Up @@ -36,16 +35,6 @@ void OnEnable()

public void Initialize()
{
GameVersion.Initialize();
if (extraVersions != null)
{
foreach (var extraVersion in extraVersions)
{
extraVersion.Version.Initialize();
}
}


if (!Application.isEditor)
{
var defaultStaceTraceSetting = Application.GetStackTraceLogType(LogType.Log);
Expand Down Expand Up @@ -127,23 +116,26 @@ public class VersionNumber
public int Minor;
public int Build;

private Dictionary<VersionDeliniator, string> version;

public string Version(VersionDeliniator deliniator = VersionDeliniator.Dot) => version[deliniator];

public void Initialize()
public string Version(VersionDeliniator deliniator = VersionDeliniator.Dot)
{
version = new Dictionary<VersionDeliniator, string>()
switch (deliniator)
{
{VersionDeliniator.Dot, $"{Major}.{Minor}.{Build}"},
{VersionDeliniator.Underscore, $"{Major}_{Minor}_{Build}"}
};
case VersionDeliniator.Dot:
return $"{Major}.{Minor}.{Build}";
case VersionDeliniator.Underscore:
return $"{Major}_{Minor}_{Build}";
default:
throw new InvalidEnumArgumentException(nameof(deliniator), (int)deliniator,
typeof(VersionDeliniator));
}
}

public override string ToString()
[Obsolete("No longer does anything")]
public void Initialize()
{
return version[VersionDeliniator.Dot];
}

public override string ToString() => Version();
}

[Serializable]
Expand Down