Repository navigation
Update CI.yml - #418
Merged
Merged
Update CI.yml#418
Conversation
Remove python 3.8 test
mattloose
requested review from
Adoni5,
alexomics,
andrew-gavin and
satriobio
October 26, 2026 20:21
Contributor
Author
|
Actually - this may not be the correct course of action. CI has broken on python 3.8 - need to determine why. |
Contributor
Author
|
Issue is that minknow-api no longer supports python 3.8. Therefore I think we should also drop support. This will require removing python 3.8 from the tests and then formally dropping python 3.8 from the project. First step is to re enable tests. If one of the requested reviewers could approve this we can move to the next step. |
andrew-gavin
approved these changes
Oct 27, 2026
Handle issues with ubuntu versioning since the change to ubuntu latest here - actions/runner-images#14748
Actually use the right OS for this test.
andrew-gavin
approved these changes
Oct 28, 2026
alexomics
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove python 3.8 test