Repository navigation
Record unblocked reads in channel_read_latest_decision (#416) - #417
Merged
Merged
Conversation
mattloose
reviewed
Oct 26, 2026
mattloose
left a comment
mattloose
left a comment
Contributor
There was a problem hiding this comment.
With the positioning of this, the only issue I can see is that reads which do not unblock for some reason will then be sequenced to full length. We believe this is rare, but we aren't 100% certain.
mattloose
previously approved these changes
Oct 26, 2026
|
Enabling read-until logger (#390) would show how often unblocks fail? |
mattloose
marked this pull request as draft
October 27, 2026 14:28
Contributor
|
Prior to approving this, please can you formally remove python 3.8 from the list of supported python versions in pyrpoject.toml etc |
andrew-gavin
marked this pull request as ready for review
October 27, 2026 14:49
mattloose
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #416
RUClient.unblock_read_batchoverrides the base method without callingself.channel_read_latest_decision.update(reads), so chunks of an unblocked read that arrive before the unblock takes effect are processed again, even though a decision has already been made.This adds the missing call, so it is now matching
stop_receiving_batch.