Skip to content
This repository was archived by the owner on Jul 6, 2026. It is now read-only.

Fix CI/CD pipeline#91

Merged
Enes1998 merged 17 commits into
mainfrom
develop
Jun 10, 2026
Merged

Fix CI/CD pipeline#91
Enes1998 merged 17 commits into
mainfrom
develop

Conversation

@EdiAsllani

Copy link
Copy Markdown
Collaborator

What does this PR do?

This PR includes changes towards fixing CI/CD issues when deploying. Before, when develop was merged to main, TruffleHog & Trivy Scan fails were seen that didn't allow the two branches to merge.

Automatic deployment was considered, but let go since it wouldn't make sense for our developing structure. Our structure consists of changes made to develop branch with reviewing by the team. If all changes are good with features making sense and complete to our scope, then changes are manually merged to main which then auto-deploys instead.

With the current fix, the deploy process shouldn't be an issue for a while.

Related milestone

M4 - DevOps MVP

Type of change

  • New feature
  • Bug fix
  • Docs update
  • DevOps / config

Checklist

  • Code compiles and runs
  • Tests added/updated
  • No secrets or API keys committed
  • AI Log updated (if AI tools were used)

What is next?

Merge this branch to main, test if deploy and pipeline work. If issues are found again, report issues to team.

Enes1998 and others added 17 commits May 26, 2026 19:56
- Delete 18 more stale files left by main->develop merge:
  app/admin/** (full tree), app/help/, app/profile/[id]/,
  and 6 orphan error.tsx/loading.tsx whose page.tsx was already
  removed. Canonical versions remain in app/(protected)/.

- FE-2 (useReducer): refactor ProficienciesStep's three related
  useState calls (selectedSkills, isExiting, isGoingBack) into
  a single useReducer with a discriminated-union action type.

- FE-5 (Server Actions): add submitQuickFeedback Server Action
  in app/(protected)/help/actions.ts, wired into the Help page
  via useActionState. Demonstrates the "use server" boundary
  and revalidatePath; logs feedback server-side.

Lint: 0 errors. Type-check: 0 errors. Dev server boots clean.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Action resolver matches the exact git tag name; aquasecurity/trivy-action
publishes tags as v-prefixed (v0.36.0, v0.35.0, ...), not bare (0.36.0).
Earlier bump used the bare form and CI failed at action resolution.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…rivy

fix: dedupe app/* pages, fix Trivy/Gitleaks, close FE-2/FE-5 gaps
ci: add develop to push + pull_request triggers
ci: jest.config TS->JS (drop ts-node), develop triggers, codeql v4, t…
ci: jest.config TS->JS, develop triggers, trufflehog auto-detect, sar…
…with userid, signalr hardened during negotiation
…ugh regardless of how busy the rest of the API is
# Conflicts:
#	.github/workflows/ci.yml
#	backend/src/Loopless.Application/Interfaces/IFileStorageService.cs
#	backend/src/Loopless.Infrastructure/Identity/KeycloakAdminClient.cs
#	backend/src/Loopless.Infrastructure/Storage/FileStorageService.cs
#	frontend/client/app/(protected)/messages/page.tsx
#	frontend/client/components/ui/GettingStartedChecklist.tsx
#	frontend/client/hooks/useGettingStartedChecklist.ts
#	frontend/client/jest.config.js
…erlays

The overlays referenced a secrets.yaml that never existed, breaking
'kubectl kustomize' builds. Production deploys via the Helm chart
(devops/helm/loopless) to namespace project-01; mark the overlays as
reference-only for a future self-managed cluster.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The merge of main brought devops/k8s/project-01/{README.md,secret.example.yaml},
whose placeholder connection strings (Password=$DB / Password=__DB__) trip the
SQLServer detector as 'unverified' findings and fail the scan under
--results=verified,unknown. Scope-exclude just those two doc files via
--exclude-paths; all detectors stay active for the rest of the repo.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@EdiAsllani EdiAsllani requested a review from Enes1998 June 10, 2026 10:29
@Enes1998 Enes1998 merged commit fdf7214 into main Jun 10, 2026
11 of 12 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants