Skip to content
This repository was archived by the owner on Jul 6, 2026. It is now read-only.

ci: TruffleHog scans merges + Node24 opt-in#90

Merged
Enes1998 merged 1 commit into
mainfrom
fix/ci-quality
Jun 7, 2026
Merged

ci: TruffleHog scans merges + Node24 opt-in#90
Enes1998 merged 1 commit into
mainfrom
fix/ci-quality

Conversation

@Enes1998

@Enes1998 Enes1998 commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Addresses two CI warnings:

  1. TruffleHog "BASE and HEAD commits are the same" — the step used base=default_branch + head=HEAD, so on a push/merge to main base==head and it scanned nothing (secret scanning only ran on PRs). Now: PR → scan the PR diff; push → scan the pushed before..after range. So merges to main are actually scanned.
  2. Node 20 deprecation — added FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true (workflow env) so the Node20-based actions (checkout, etc.) run on Node 24 ahead of GitHub's 2026-06-16 forced migration, clearing the warnings.

One-file change to ci.yml. YAML validated.

- TruffleHog used base=default_branch + head=HEAD, so on push/merge to main base==head
  and it scanned NOTHING (only PRs were scanned). Use the PR diff on pull_request and
  the pushed before..after range on push, so merges to main are actually scanned.
- Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true so Node20-based actions run on Node24
  (GitHub force-migrates 2026-06-16), clearing the deprecation warnings.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Enes1998 Enes1998 merged commit e93f120 into main Jun 7, 2026
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant