Skip to content

Set up Copilot instructions following best practices - #82

Open
paulpv with Copilot wants to merge 4 commits into
mainfrom
copilot/set-up-copilot-instructions
Open

Set up Copilot instructions following best practices#82
paulpv with Copilot wants to merge 4 commits into
mainfrom
copilot/set-up-copilot-instructions

Conversation

Copilot AI commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Enhanced .github/copilot-instructions.md with missing best practice elements for effective AI-assisted development.

Additions

  • Quick Start for Contributors - Cross-platform setup commands and workflow checklist
  • Example Code Patterns - Concrete examples showing correct vs incorrect patterns:
    // Good - uses AppSettings wrapper
    AppSettings s;
    s.setValue("myKey", value);
    
    // Good - uses Qt::CTRL (maps to Cmd on macOS, Ctrl elsewhere)
    action->setShortcut(QKeySequence(Qt::CTRL | Qt::Key_T));
    
    // Good - surgical removal preserves other frames
    removeSingleFrame(frameToRemove);
    // Bad - rebuilds all frames, stops media playback
    rebuildSections();
  • Security Considerations - Distinction between user preferences (AppSettings) and sensitive data (platform keychain)
  • Testing Strategy - Platform coverage expectations and manual verification requirements
  • Common Pitfalls - Frame lifecycle, QSettings prohibition, memory management, signal connections

Changes

File grew from 116 to 201 lines. Existing content preserved; all additions provide actionable guidance for critical project conventions.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • gh.io
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>✨ Set up Copilot instructions</issue_title>
<issue_description>Configure instructions for this repository as documented in Best practices for Copilot coding agent in your repository.

@copilot, isn't this already done? Why does GitHub keep hinting to do this at the top of new PRs?</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits January 12, 2026 23:01
Co-authored-by: paulpv <1393897+paulpv@users.noreply.github.com>
Co-authored-by: paulpv <1393897+paulpv@users.noreply.github.com>
…latforms

Co-authored-by: paulpv <1393897+paulpv@users.noreply.github.com>
Copilot AI changed the title [WIP] Configure Copilot instructions for repository Set up Copilot instructions following best practices Jan 12, 2026
Copilot AI requested a review from paulpv January 12, 2026 23:05
@paulpv
paulpv marked this pull request as ready for review January 12, 2026 23:10
Copilot AI review requested due to automatic review settings January 12, 2026 23:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Set up Copilot instructions

3 participants