Repository navigation
Test: Count a parked window at its nearest monitor's scale - #178
Merged
Merged
Conversation
A window opened on a 200 percent primary and parked nearest a 125 percent monitor rightly takes that monitor's scale, and the check that the scale never changed made every scene NOT_DRIVEN on such a machine. The parked window must now settle at the DPI of the monitor it is nearest, which still rejects a window that dropped to the system scale on a single 200 percent monitor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run65 on this PC (primary 2880x1800 at 200 percent, two 2560x1440 at 125 percent to its right) gave NOT_DRIVEN for every scene: "the window's scale changed after it was parked: 192 then 120". The browser opens on the primary at 192 and the park at 9000,1000 is nearest the lower 125 percent monitor, so it re-lays out at 120, which is what a person's window there has.
The park check now requires the last traced layout DPI to equal the effective DPI of the window's nearest monitor (MonitorFromWindow + GetDpiForMonitor, on the per-monitor aware harness thread).
Get-ParkScaleErrorin windows-features-lib.ps1 is pure; the selftest casenfr5_a_parked_window_counts_at_its_nearest_monitors_scale_onlycovers 192 then 120 at a 120 monitor (counts), the single 200 percent drop 192 then 96 at a 192 monitor (rejected), and a window left at 192 nearest a 120 monitor (rejected).🤖 Generated with Claude Code