Repository navigation
Feat: Anchor bubbles where Chromium puts the address row - #176
Merged
Merged
Conversation
Where the row carries a checked ConvertPointToScreen, the page, address and chip a bubble anchors to come from the window corner Chromium reports, which is the place its own bubbles use. Rows without it, Whale and Samsung Internet keep the place derived from the window's monitor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step two of the bubble anchor redesign, after #175's read-only trace. Where the build's row carries a checked
screen_origin(views::View::ConvertPointToScreen), the GetAnchorRect hook anchors to the page, address and chip placed from Chromium's own screen DIP origin of the frame view; otherwise it keeps today's MonitorFromWindow derivation. Pure functionplacedwith its test infr12_rows_move_with_the_window_corner_chromium_reports.Draft until a CI drive's trace shows the
same/offreading.🤖 Generated with Claude Code