fix(cli): allow local session creation on stale Flock sync - #411
Open
UniversePeak wants to merge 1 commit into
Open
fix(cli): allow local session creation on stale Flock sync#411UniversePeak wants to merge 1 commit into
UniversePeak wants to merge 1 commit into
Conversation
Model: gpt-5.6-luna
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #398
Problem / pressure
When the machine Flock freshness sync fails during degraded network conditions, MCP/local session creation rejects a project that is already available in the local replica. The remote round trip is a freshness check, not a prerequisite for resolving the local project needed to create the session.
Summary
Keep the existing hard-fail sync helper for callers that require fresh reads, but use a best-effort wrapper for both local-project resolution paths. A failed freshness sync is logged and resolution continues from the local Flock replica.
Before / after
Test plan
corepack pnpm exec vitest run src/commands/session.test.ts --pool=forks --maxWorkers=1— 65 tests passed.syncFlockDocOrThrowto reject withStreams sync failed: network_errorand verifies local project resolution still succeeds.git diff --checkpassed.Context handoff
Instructions for reviewing agents
apps/cli/src/commands/session.tslocal-project resolution paths and confirm the best-effort wrapper does not alter agent-config or ACP capability freshness reads.Authoring context