Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1617,8 +1617,13 @@ export function MobileHomeScreen({

<div
ref={listScrollRef}
data-mobile-session-list-scroll-region=""
className={cn(
'mobile-home-list-region scrollbar-pro relative min-h-0 flex-1 overflow-y-auto pt-1 [scrollbar-gutter:auto]',
/* `z-0` makes the scroller a stacking context. WebKit can
otherwise promote the positioned / animated conversation
rows beside its overflow-controls layer, letting row
backgrounds paint over the vertical scrollbar. */
'mobile-home-list-region scrollbar-pro relative z-0 min-h-0 flex-1 overflow-y-auto pt-1 [scrollbar-gutter:auto]',
'pb-[calc(var(--mobile-tabbar-height)+var(--k-safe-area-bottom,0px)+1rem)]'
)}
>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
// @vitest-environment jsdom

import React, { type ReactNode } from 'react';
import { flushSync } from 'react-dom';
import { createRoot, type Root } from 'react-dom/client';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { MobileHomeScreen } from '../src/components/mobile/mobile-home-screen';
import { initI18n } from '../src/i18n';

describe('mobile session list scrollbar layer', () => {
let root: Root | undefined;
let container: HTMLDivElement | undefined;

beforeEach(async () => {
await initI18n('en');
Object.defineProperty(window, 'matchMedia', {
configurable: true,
value: vi.fn().mockImplementation((query: string) => ({
matches: false,
media: query,
onchange: null,
addEventListener: vi.fn(),
removeEventListener: vi.fn(),
addListener: vi.fn(),
removeListener: vi.fn(),
dispatchEvent: vi.fn(),
})),
});
});

afterEach(() => {
if (root) {
flushSync(() => root?.unmount());
}
root = undefined;
container?.remove();
container = undefined;
vi.restoreAllMocks();
});

function render(node: ReactNode) {
container = document.createElement('div');
document.body.appendChild(container);
root = createRoot(container);
flushSync(() => root?.render(node));
}

function expectScrollbarStackingBoundary() {
const scrollRegion = container?.querySelector('[data-mobile-session-list-scroll-region]');
expect(scrollRegion).not.toBeNull();
expect(scrollRegion?.classList).toContain('relative');
expect(scrollRegion?.classList).toContain('z-0');
expect(scrollRegion?.classList).toContain('overflow-y-auto');
}

it('keeps the workspace conversation rows inside the scroll container stacking context', () => {
render(
<MobileHomeScreen
workspace={{ id: 'workspace', name: 'Workspace' }}
machines={[]}
selectedTab="chat"
localProjects={[]}
githubRepositories={[]}
chats={[]}
/>
);

expectScrollbarStackingBoundary();
});
});
Loading