Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions apps/cli/tests/agent-setting.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,29 @@ describe('resolveBuiltinACPSetting', () => {
});
});

it('uses the direct ACP launch from the Factory Droid registry entry', () => {
const agent = getRegistryAgent('factory-droid');
const npx = agent.distribution.npx;
if (!npx) {
throw new Error('Expected Factory Droid to have an npx distribution');
}

expect(npx.package).toBe(`droid@${agent.version}`);
expect(npx.args).toEqual(expect.arrayContaining(['exec', '--output-format', 'acp']));
expect(npx.args).not.toContain('acp-daemon');
expect(resolveACPSetting({ cliType: 'registry', agentType: 'factory-droid' })).toEqual({
status: { agent: `Factory Droid@${agent.version}`, command: 'npx' },
exec: {
command: 'npx',
args: ['--prefer-offline', '-y', npx.package, ...(npx.args ?? [])],
env: npx.env,
},
});
expect(getAcpCapabilitySourceVersion({ cliType: 'registry', agentType: 'factory-droid' })).toBe(
`factory-droid@${agent.version}`
);
});

it('uses the hardcoded Interactive Claude registry provider with exact platform npx packages', () => {
const agent = getRegistryAgent('claude-p');
const npx = agent.distribution.npx;
Expand Down
6 changes: 3 additions & 3 deletions packages/shared/src/acp/registry-generated.ts
Original file line number Diff line number Diff line change
Expand Up @@ -418,16 +418,16 @@ const REMOTE_REGISTRY_ACP_AGENTS: RegistryAcpAgent[] = [
{
id: 'factory-droid',
name: 'Factory Droid',
version: '0.208.2',
version: '0.212.0',
description: 'Factory Droid - AI coding agent powered by Factory AI',
icon: 'https://cdn.agentclientprotocol.com/registry/v1/latest/factory-droid.svg',
distribution: {
npx: {
package: 'droid@0.208.2',
package: 'droid@0.212.0',
args: [
'exec',
'--output-format',
'acp-daemon'
'acp'
],
env: {
DROID_DISABLE_AUTO_UPDATE: 'true',
Expand Down
6 changes: 6 additions & 0 deletions scripts/generate-acp-registry.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,12 @@ function normalizeRegistryAgent(agent) {
return null;
}

if (id === 'factory-droid' && distribution.npx?.args) {
distribution.npx.args = distribution.npx.args.map((arg) =>
arg === 'acp-daemon' ? 'acp' : arg
);
}

return {
id,
name,
Expand Down
Loading