chore(deprivatize): scrub Vista codename and Libraxis org references#2
Conversation
…ifact symlinks
Drop docs/ARCHITECTURE_{ACTUAL,COMPARISON,PROMISED}.md: internal session
status snapshots reconstructing the private deployment (host names, launchd
labels, port topology) — not part of the public docs surface (docs/index.html).
Remove .vibecrafted/{plans,reports} symlinks that pointed into a private home
artifact tree and were tracked despite the /.vibecrafted gitignore rule.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ders Replace personal names and emails (Maciej/Monika/Klaudiusz, void@div0.space, the1st@whoai.am), 'M&K' and 'The LibraxisAI Team' credit lines with the collective 'vetcoders' / hello@vetcoders.io across package metadata, LICENSE, CI/workflow headers, hook scripts, docs footers, and the changelog. Normalize camelCase brand 'VetCoders' to 'Vetcoders' (lowercase in the git URL). Replace a private shared-volume path in the configuration example with a neutral path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ests Replace the private host name 'dragon' with neutral placeholders in CLI/API doc-comment examples and in query-router/keyword-extraction test inputs (intent and filtering semantics preserved; tests still pass). Replace a real home path in a keyword-extraction test fixture with a neutral path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rename for_vista() -> for_app_optimized() (no callers), genericize Vista project/codename in fixtures, docs and CLI help to neutral names, switch ai.libraxis.* launchd label to ai.vetcoders.*, drop LibraxisShare path and LibraxisAI copyright line. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive rebranding and cleanup across the codebase, replacing specific references to "Vista", "Dragon", and "The LibraxisAI Team" with generic terms like "Demo", "laptop", and "Vetcoders". Key changes include renaming MemexEngine::for_vista() to MemexEngine::for_app_optimized(), updating documentation, and removing architecture comparison markdown files. The review feedback suggests a minor simplification in src/engine.rs to remove a redundant db_path setting that already matches the default fallback behavior.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 228e2ba2ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Two things CI (clippy -D warnings + tests on latest stable) flagged on this
branch:
1. The de-privatization scrub renamed the project_id-match test inputs
inconsistently: the asserted-positive case checked project_id "Loctree"
against filter "vetcoders", which can never match. Restored to a consistent
positive match ("Loctree" vs "loctree"); the matcher logic itself
(matches_project_filter / metadata_matches_project) was never touched.
2. Pre-existing clippy debt the newer stable enforces: unnecessary_sort_by
(-> sort_by_key with Reverse, behaviour-identical) and collapsible match
guards. Machine-applicable autofixes + the equivalent sort_by_key rewrites.
Behaviour unchanged: clippy/fmt clean, full test suite (lib+bins+tests) passes.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Line 636 in 493d942
Replace residual private hostnames in README
In this scrubbed public README section, the lead-in now uses generic machines, but the per-host bullet immediately below still publishes the old concrete hostnames (dragon, mgbook16). That leaves the same private machine identifiers visible in the main user-facing docs after the deprivatization pass, so please replace these suffix examples with generic hostnames as well.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Same cross-platform clippy issue as the sibling repo: the cfg'd non-macOS early return makes the macOS ioreg body unreachable, which CI's clippy -D warnings on ubuntu promotes to an error (macOS builds never compile the early return). Scope the allow to non-macOS. Pre-existing, not from the de-privatization scrub. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rename the private-host 'dragon' embedding provider to a neutral 'embedder' and drop the hardcoded remote host default: - provider name dragon -> embedder - env DRAGON_BASE_URL -> EMBEDDER_BASE_URL, DRAGON_EMBEDDER_PORT -> EMBEDDER_PORT - fields dragon_url/dragon_port -> embedder_url/embedder_port - default base_url http://dragon:12345 -> http://localhost:12345 - drop redundant remote-host probe in TUI detection (now duplicated localhost) - align install.sh/README env docs with code defaults - per-host path examples use host-a/host-b placeholders
- LICENSE Licensor and alternative-licensing contact point to the legal entity Libraxis AI sp. z o.o. / contact@libraxis.ai - Cargo.toml authors reflect the same legal entity Brand references (Vetcoders) in the copyright and competitive-offering clauses are intentionally retained as product/brand identity.
…L casing - fix false 'MIT OR Apache-2.0 retained' claim; the crate has always shipped under BUSL-1.1 (Apache-2.0 change license) - restore ground-truth casing of the historical VetCoders/rmcp-memex URL that a prior scrub had lowercased
Replace veterinary-domain example content (patient notes, SOAP/feline diabetes) with neutral onboarding/release-note examples. The GDPR deletion example keeps the load-bearing for_patient() API and 'patients' namespace unchanged.
…ures - translate the Polish transcript test fixture to neutral English and drop the aicx-dragon endpoint reference (turn structure preserved) - use /Users/tester placeholder in the keyword-extraction fixture - HTTP_API.md: synthetic round document counts and neutral 'notes' namespace in discovery/search examples
Translate docs/01_security.md and docs/02_configuration.md from Polish to English 1:1 without substantive editing. Example namespace names in the security guide are rendered with their English equivalents for a coherent English document; code blocks, paths, hashes, and tables are unchanged.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 461e07948e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ethnum 1.5.2 uses mem::transmute(()) which fails E0512 (cannot transmute between types of different sizes) on newer toolchains. 1.5.3 fixes the transitive lancedb->jsonb->ethnum build. Lockfile-only bump.
rustc 1.97's useless_borrows_in_formatting lint flags `&r.id` in the eprintln! args, so the clippy -D warnings CI gate fails on it once the ethnum build is unblocked. Pass r.id by value.
for_app_optimized() hardcoded db_path to "~/.rmcp-servers/app/lancedb", exactly what effective_db_path() derives from app_name="app". Set db_path: None so effective_db_path() stays the single source of truth. No behavioral change.
After the dragon->embedder rename (2c50593), an existing config.toml with [mlx] dragon_url/dragon_port had those keys silently ignored by serde, falling back to the env/default localhost embedder on upgrade. Add serde aliases on embedder_url/embedder_port and cover both spellings with deserialization tests.
The unreleased entry stated the license but was silent on the author metadata change. Note Libraxis AI as Licensor and Cargo author so the release note matches Cargo.toml and LICENSE.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b362717259
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
MlxConfig::from_env() read only the renamed EMBEDDER_BASE_URL / EMBEDDER_PORT vars, so env-driven deployments still setting the pre-rename DRAGON_BASE_URL / DRAGON_EMBEDDER_PORT (commit 2c50593) silently fell back to the localhost default on upgrade. Prefer the neutral names, fall back to the legacy ones. Mirrors the [mlx] TOML aliases; precedence covered by a pure unit test.
The install snippet pinned rust-memex = "0.5", but the crate is already 0.6.0 and the Optimized Profile example calls for_app_optimized(), which only exists in 0.6. Align the dependency example with the version that ships the documented API.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d1d52fc37
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
local_port only builds the localhost provider (http://localhost:{port}),
so inheriting the legacy DRAGON_EMBEDDER_PORT (a remote-host port) made
the local probe skip a working localhost:12345 server. Scope the DRAGON_*
fallback to the remote embedder provider (embedder_url/embedder_port) and
keep local_port on EMBEDDER_PORT or the 12345 default.
The historical [0.3.0] entry named for_app_optimized(), a constructor name that did not exist in that release. Describe the optimized-profile constructor without asserting an anachronistic method name.
1 participant
Deprivatize pass + second-pass residual scrub for public-release hygiene,
followed by a decisions pass that resolves every open REVIEW from the leak
audit via explicit operator rulings (2026-07-09).
Initial scrub
MemexEngine::for_vista()->for_app_optimized()(no in-tree callers).Vistaproject/codename across fixtures, docs and CLI help.ai.libraxis.*launchd label ->ai.vetcoders.*./Volumes/LibraxisSharepath andLibraxisAIcopyright line.Decisions pass (operator rulings, 2026-07-09)
Every REVIEW item flagged by the read-only audit was adjudicated by the
operator; this branch executes those rulings as atomic commits:
dragonembeddingprovider -> neutral
embedder; envDRAGON_BASE_URL/DRAGON_EMBEDDER_PORT->
EMBEDDER_BASE_URL/EMBEDDER_PORT; struct fieldsdragon_url/dragon_port->embedder_url/embedder_port; defaultbase URL
http://dragon:12345->http://localhost:12345. Docs(
install.sh, README env + per-host examples) realigned with code.authorsset to the legalentity
Libraxis AI sp. z o.o. <contact@libraxis.ai>; brand references(Vetcoders) retained in copyright/competitive clauses as product identity.
claim (the crate ships under BUSL-1.1) and restored the ground-truth
casing of the historical
VetCoders/rmcp-memexURL.security@loct.io-> confirmedsecurity@loctree.com.loctree-ci.ymlcredit header unified to the Loctreecopyright form used by the other
.githubfiles.SOAP / feline diabetes) generalized to a neutral notes/records domain.
The load-bearing
MetaFilter::for_patient()API andpatientsnamespaceare intentionally retained.
and the
aicx-dragonendpoint reference dropped (turn structurepreserved);
/Users/testerplaceholder in the keyword fixture;HTTP_API.mdgiven synthetic round document counts and a neutralnotesnamespace.
docs/01_security.mdanddocs/02_configuration.mdtranslated from Polish to English 1:1.
Out of scope by ruling: the
ai.vetcoders.rust-memexlaunchd label stays.Notes
EMBEDDER_PORTwas already readfor the local MLX port, so folding
DRAGON_EMBEDDER_PORTintoEMBEDDER_PORTcollapses the remote/local port into a single knob (bothnow read
EMBEDDER_PORT). This matches the intent of dropping thehardcoded remote host and is documented here for visibility.
~/.rmcp-servers/rust-memex/lancedbwhile the TUI wizard's per-host default is
~/.ai-memories/lancedb.<host>.These are two distinct entrypoints and the docs already match each; no
doc↔code drift required a change.
Gates
cargo fmt --check+cargo clippy --all-targets -- -D warnings+cargo testall green (278 tests passed, 0 failed). Brand/productidentifiers (loctree, vetcoders, rust-memex, vibecrafted, aicx) intentionally
retained.
🤖 Generated with Claude Code