fix(ci): quarantine E2E asserts fixture file name — windows path rendering (round 3)#38
Conversation
…t exact path rendering - windows-latest: cargo test padoł na stderr.contains(invalid.display()) — Windows renderuje ścieżkę inaczej (kanonizacjo/verbatim \\?\ prefix) niż surowe display() z testu - asercjo przeniesióno na unikalnóm nazwę pliku fixture (UUID.jsonl): dalij dowodzi, że skip wskazuje winne źródło; session_id trzymo osobny assert - unix: test zielóny lokalnie (1 passed) Authored-By: claude <agents@vetcoders.io> session_id: 49a84e4c-f24d-4167-9f55-ae0f8123a66f timestamp: 2026_0715_0504_CEST runtime: claude-code-interactive
There was a problem hiding this comment.
Code Review
This pull request updates the integration test in tests/runtime_cli_store_contract.rs to assert against the file name of the invalid fixture instead of its full path display string. This prevents test failures on platforms like Windows where path rendering can differ due to canonicalization. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
Adjusts the E2E quarantine assertions to be platform-agnostic on Windows by avoiding strict matching on Path::display() output, while still proving that the skipped source corresponds to the intended fixture.
Changes:
- Replaces
stderr.contains(invalid.display())with an assertion against the unique fixture file name (UUID-based), sidestepping Windows-specific path rendering (e.g.,\\?\verbatim prefixes). - Reuses the extracted
invalid_namefor both the stderr assertion and the diagnostics log assertion to keep the test intent consistent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Runda 3 zzielenianio main po #35: windows-latest cargo test padoł na
stderr.contains(invalid.display())w E2E kwarantanny (R2) — Windows renderuje ścieżkę inaczej niż surowedisplay(). Asercjo przeniesióno na unikalny UUID-owy filename fixture'a (dalij dowodzi wskazanio winnego źródła; session_id trzymo osobny assert). Unix: test zielony lokalnie.𝚅𝚒𝚋𝚎𝚌𝚛𝚊𝚏𝚝𝚎𝚍. with AI Agents by VetCoders (c)2024-2026 LibraxisAI