fix(ci): cfg(unix)-gate golden-test imports — windows clippy round 2#37
Conversation
… clippy unused-imports - runda 2 po #36: dead-code helpery zgate'owane, ale ich importy (write_canonical_projection_at, engine::{AgentKind,...}, projections::{CANONICAL_CARD_SCHEMA,...}) zostały bezwarunkowe -> windows-latest clippy -D warnings: 3x unused_imports - gate importów tym samym cfg(unix); clippy raportuje wszystkie unused naraz, więc to je domkniynty zbiór (żodnych kolejnych sierot w logu rundy 2) - pełno replikacjo cross-clippy na macu niemożliwo (llama-cpp-sys bindgen wymago windows SDK) — dowód z analizy logu CI + statycznej Authored-By: claude <agents@vetcoders.io> session_id: 49a84e4c-f24d-4167-9f55-ae0f8123a66f timestamp: 2026_0715_0421_CEST runtime: claude-code-interactive
There was a problem hiding this comment.
Pull request overview
This PR fixes Windows CI (clippy -D warnings) by cfg(unix)-gating golden-test-only imports in src/overlay.rs, aligning them with already-#[cfg(unix)] helper types/functions used exclusively by a Unix-only golden test.
Changes:
- Added
#[cfg(unix)]to imports of golden-test helpers so they don’t triggerunused_importsonwindows-latest. - Kept Unix test behavior intact by matching the existing
#[cfg(unix)]gating already present on the helper structs/functions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds #[cfg(unix)] attributes to several test imports in src/overlay.rs to restrict them to Unix platforms. The reviewer suggested grouping the imports from aicx_parser under a single #[cfg(unix)] block to improve readability and simplify the structure.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| #[cfg(unix)] | ||
| use aicx_parser::engine::{ | ||
| AgentKind, BoundaryFlags, ParseStatus, TurnKind, VisibleCompleteness, | ||
| }; | ||
| #[cfg(unix)] | ||
| use aicx_parser::projections::{ | ||
| CANONICAL_CARD_SCHEMA, CanonicalProjection, ProjectAttribution, ProjectBucket, | ||
| TimelineFrame, |
There was a problem hiding this comment.
Zamiast powtarzać atrybut #[cfg(unix)] dla każdego importu z biblioteki aicx_parser, można je zgrupować w jeden wspólny import. Poprawi to czytelność kodu i uprości strukturę importów w module testowym.
#[cfg(unix)]
use aicx_parser::{
engine::{AgentKind, BoundaryFlags, ParseStatus, TurnKind, VisibleCompleteness},
projections::{
CANONICAL_CARD_SCHEMA, CanonicalProjection, ProjectAttribution, ProjectBucket,
TimelineFrame,
},
}
Domkniyncie czerwonego main po #35/#36: runda 1 (#36) zgate'owała dead-code helpery golden testu, runda 2 gate'uje ich importy (3× unused_imports na windows-latest). Clippy raportuje wszystkie unused naraz — log rundy 2 nie zawiero nic poza tymi importami, więc zbiór je domkniynty.
𝚅𝚒𝚋𝚎𝚌𝚛𝚊𝚏𝚝𝚎𝚍. with AI Agents by VetCoders (c)2024-2026 LibraxisAI