Repository navigation
ci: fix macOS action shell variable naming - #213
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
=======================================
Coverage 63.91% 63.91%
=======================================
Files 5 5
Lines 546 546
Branches 212 212
=======================================
Hits 349 349
Misses 129 129
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #213 screenshots vs Matrix:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.











































Description
Rename the local
dbPathandsqlQueryvariables todb_pathandsql_queryin both macOS TCC database helpers, including their SQLite command arguments. This addresses all four opengithubactions:S7684findings in Sonar projectLizardByte_traywhile preserving the commands and database paths.Screenshot
Issues Fixed or Closed
Sonar findings:
AaGM7uUuEhlCTg74GiYn,AaGM7uUuEhlCTg74GiYo,AaGM7uUuEhlCTg74GiYp, andAaGM7uUuEhlCTg74GiYq.Roadmap Issues
Testing
git diff --check --ignore-submodules=all: passed..yamllint.yml: passed.runblock and checked it withbash -nunder MSYS2 UCRT64: passed.No unit tests were added because this only renames local shell variables. macOS TCC database execution was not run on the Windows host.
Type of Change
Checklist
AI Usage
See our AI usage policy.