Repository navigation
fix(sunshine): support CMake 4.5 with Boost.Locale backport - #107
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
CMake 4.5.0 rejects Boost.Locale's source group because
include/boost/locale.hppsits outside the declaredinclude/boost/locale/tree, preventing the stable Sunshine package from configuring.Download the pinned Boost 1.89.0 archive through makepkg, apply the combined upstream fixes from 1d070743 and f51b58cd in
prepare(), and setFETCHCONTENT_SOURCE_DIR_BOOSTso CMake uses those patched sources. Bumppkgrelto 3 and regenerate.SRCINFO.Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
bash -n PKGBUILDpassed..SRCINFOwith_use_cuda=true makepkg --printsrcinfo.patch --dry-run -Np1and patch application succeeded against the actual Boost 1.89.0 archive.FETCHCONTENT_SOURCE_DIR_BOOST(Windows/MSVC).git diff --checkand the staged whitespace check passed.No permanent regression test was added because this packaging repository has no standalone test harness; the focused before/after configure check exercised the failure, and the existing Arch package build workflow provides full-package validation. A full Arch package build was not run locally and remains for CI.
Type of Change
Checklist
AI Usage
See our AI usage policy.
Codex assisted with investigation, the packaging backport, focused validation, and this PR description.