Skip to content

fix(sunshine): support CMake 4.5 with Boost.Locale backport - #107

Merged
ReenigneArcher merged 1 commit into
masterfrom
codex/fix-boost-locale-cmake-4-5
Nov 13, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
codex/fix-boost-locale-cmake-4-5

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

CMake 4.5.0 rejects Boost.Locale's source group because include/boost/locale.hpp sits outside the declared include/boost/locale/ tree, preventing the stable Sunshine package from configuring.

Download the pinned Boost 1.89.0 archive through makepkg, apply the combined upstream fixes from 1d070743 and f51b58cd in prepare(), and set FETCHCONTENT_SOURCE_DIR_BOOST so CMake uses those patched sources. Bump pkgrel to 3 and regenerate .SRCINFO.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • bash -n PKGBUILD passed.
  • Regenerated .SRCINFO with _use_cuda=true makepkg --printsrcinfo.
  • Verified the Boost release archive and local patch SHA-256 checksums against the package metadata.
  • GNU patch --dry-run -Np1 and patch application succeeded against the actual Boost 1.89.0 archive.
  • CMake 4.5.0 configuration of Boost.Locale through FetchContent reproduced the reported error before the patch and configured/generated successfully afterward using FETCHCONTENT_SOURCE_DIR_BOOST (Windows/MSVC).
  • git diff --check and the staged whitespace check passed.

No permanent regression test was added because this packaging repository has no standalone test harness; the focused before/after configure check exercised the failure, and the existing Arch package build workflow provides full-package validation. A full Arch package build was not run locally and remains for CI.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

Codex assisted with investigation, the packaging backport, focused validation, and this PR description.

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit 9ba420c into master Nov 13, 2026
10 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/fix-boost-locale-cmake-4-5 branch November 13, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake 4.5.0 causes boost CMake issues

1 participant