Repository navigation
fix(sunshine): inline single-use formula helpers - #467
Merged
Merged
Conversation
7 of 18 tasks
Member
Author
|
Member
|
Bottles have been added to this PR. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Homebrew's new
Homebrew/SingleUseMethodcop rejects 20 helper methods in each Sunshine formula, causing audit and tap-wide style checks to fail. Inline these helpers at their call sites insunshine.rbandsunshine-beta.rb, and document the updated build, test, and coverage entry points.Both formulae need the change because Sunshine CI validates the entire tap in addition to its newly generated formula. Test configuration and fixture installation stay in separate methods to keep
installbelow SonarCloud’s complexity limit.The bottle workflow prepares the required
libexecdirectory before Homebrew cleanup on Intel macOS. For the pinned stable Sunshine release, the formula stages the original Boost 1.89 archive and applies the Boost.Locale CMake 4.5 fix before Sunshine configures its fallback dependency.Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
ruby -cpassed for both formulae.brew style lizardbyte/homebrewpassed: 8 files inspected, no offenses.b43c73f8231d0308a0ce047bd8ad6e8dc6309f24in WSL Ubuntu 24.04.source_grouperror with CMake 4.5. The patched Boost 1.89 source configured and builtboost_locale, and Homebrew successfully staged the checksum-verified resource.brew style, andactionlintpassed locally. Both Intel macOS jobs passed on the runner setup fix. Bottle builds for the stable Boost backport run in hosted CI.Type of Change
Checklist
AI Usage
See our AI usage policy.
AI assisted with the formula refactor, validation, and this description.