Skip to content

fix(sunshine): inline single-use formula helpers - #467

Merged
ReenigneArcher merged 6 commits into
masterfrom
codex/fix-sunshine-single-use-methods
Nov 17, 2026
Merged

ReenigneArcher merged 6 commits into
masterfrom
codex/fix-sunshine-single-use-methods

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Description

Homebrew's new Homebrew/SingleUseMethod cop rejects 20 helper methods in each Sunshine formula, causing audit and tap-wide style checks to fail. Inline these helpers at their call sites in sunshine.rb and sunshine-beta.rb, and document the updated build, test, and coverage entry points.

Both formulae need the change because Sunshine CI validates the entire tap in addition to its newly generated formula. Test configuration and fixture installation stay in separate methods to keep install below SonarCloud’s complexity limit.

The bottle workflow prepares the required libexec directory before Homebrew cleanup on Intel macOS. For the pinned stable Sunshine release, the formula stages the original Boost 1.89 archive and applies the Boost.Locale CMake 4.5 fix before Sunshine configures its fallback dependency.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • ruby -c passed for both formulae.
  • Full brew style lizardbyte/homebrew passed: 8 files inspected, no offenses.
  • The three refactored formulae (the tap's stable and beta formulae plus Sunshine's CMake-generated formula) passed current Homebrew style checks with Homebrew/brew at b43c73f8231d0308a0ce047bd8ad6e8dc6309f24 in WSL Ubuntu 24.04.
  • Packaging-only refactor, validated with the actual Homebrew lint checks; no new build-system test fixtures were added.
  • Reproduced the original Boost.Locale source_group error with CMake 4.5. The patched Boost 1.89 source configured and built boost_locale, and Homebrew successfully staged the checksum-verified resource.
  • The stable formula’s install smoke test reproduced the earlier pip failure. The corrected formula installed and imported MarkupSafe and Jinja2, staged the patched Boost archive separately, and configured the pinned release’s Boost fallback with CMake 4.5.
  • Ruby syntax, tap-wide brew style, and actionlint passed locally. Both Intel macOS jobs passed on the runner setup fix. Bottle builds for the stable Boost backport run in hosted CI.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

AI assisted with the formula refactor, validation, and this description.

This pull request was generated by Codex (GPT-6; thinking level not exposed by this session).

Copy link
Copy Markdown
Member Author

This pull request was generated by Codex (GPT-6; thinking level not exposed by this session).

@ReenigneArcher ReenigneArcher added the pr-pull Approve a PR that modifies a formula. label Nov 17, 2026
@LizardByte-bot

LizardByte-bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Bottles have been added to this PR.

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit 356677d into master Nov 17, 2026
23 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/fix-sunshine-single-use-methods branch November 17, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bottle-published pr-pull Approve a PR that modifies a formula. sunshine sunshine-beta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants