Skip to content

fix: remove review requests #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Livinglist merged 3 commits into from
Oct 10, 2026
Merged

fix: remove review requests #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
674f921
fix: remove review request
Livinglist Oct 10, 2026
7bd27f4
update
Livinglist Oct 10, 2026
70652b4
update
Livinglist Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ pluginManagement {

plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
id "com.android.application" version "9.0.1" apply false
id "com.android.application" version "9.1.0" apply false
id "org.jetbrains.kotlin.android" version "2.3.20" apply false
}

Expand Down
2 changes: 0 additions & 2 deletions lib/screens/item/item_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,6 @@ class _ItemScreenState extends State<ItemScreen>
),
onTap: () {
HapticFeedbackUtils.light();
locator.get<AppReviewService>().requestReview();
context.read<PreferenceCubit>().update(
FontSizePreference(val: fontSize.index),
);
Expand Down Expand Up @@ -588,7 +587,6 @@ class _ItemScreenState extends State<ItemScreen>
leading: const Icon(Icons.list),
title: const Text('View in separate thread'),
onTap: () {
locator.get<AppReviewService>().requestReview();
context.pop();
goToItemScreen(
args: ItemScreenArgs(
Expand Down
12 changes: 1 addition & 11 deletions lib/screens/item/widgets/more_popup_menu.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,12 @@ import 'package:flutter_feather_icons/flutter_feather_icons.dart';
import 'package:go_router/go_router.dart';
import 'package:hacki/blocs/blocs.dart';
import 'package:hacki/config/constants.dart';
import 'package:hacki/config/locator.dart';
import 'package:hacki/cubits/cubits.dart';
import 'package:hacki/extensions/extensions.dart';
import 'package:hacki/models/models.dart';
import 'package:hacki/screens/item/models/models.dart';
import 'package:hacki/screens/screens.dart';
import 'package:hacki/screens/widgets/widgets.dart';
import 'package:hacki/services/services.dart';
import 'package:hacki/styles/styles.dart';
import 'package:hacki/utils/utils.dart';
import 'package:material_ui/material_ui.dart';
Expand Down Expand Up @@ -137,21 +135,13 @@ class MorePopupMenu extends StatelessWidget {
actions: <Widget>[
TextButton(
onPressed: () {
locator
.get<AppReviewService>()
.requestReview();
context.pop();
onSearchUserTapped(context);
},
child: const Text('Search'),
),
TextButton(
onPressed: () {
locator
.get<AppReviewService>()
.requestReview();
context.pop();
},
onPressed: context.pop,
child: const Text('Okay'),
),
],
Expand Down
10 changes: 1 addition & 9 deletions lib/services/dialog_proxy.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import 'package:flutter_bloc/flutter_bloc.dart';
import 'package:go_router/go_router.dart';
import 'package:hacki/blocs/stories/stories_bloc.dart';
import 'package:hacki/config/locator.dart';
import 'package:hacki/config/router.dart';
import 'package:hacki/cubits/comments/comments_cubit.dart';
import 'package:hacki/cubits/search/search_cubit.dart';
import 'package:hacki/models/item/item.dart';
import 'package:hacki/screens/item/widgets/time_machine_dialog.dart';
import 'package:hacki/screens/screens.dart';
import 'package:hacki/services/services.dart';
import 'package:hacki/styles/styles.dart';
import 'package:hacki/utils/haptic_feedback_utils.dart';
import 'package:material_ui/material_ui.dart';
Expand Down Expand Up @@ -133,13 +131,7 @@ abstract final class DialogProxy {
builder: (BuildContext context) => AlertDialog(
title: const Text('Download completed'),
actions: <Widget>[
TextButton(
onPressed: () {
context.pop();
locator.get<AppReviewService>().requestReview();
},
child: const Text('Noooice!'),
),
TextButton(onPressed: context.pop, child: const Text('Noooice!')),
],
),
);
Expand Down
Loading