Repository navigation
feat: separate core package, restore web3js support - #387
ChiefWoods wants to merge 8 commits into
Conversation
|
Damn that was quick haha. I'll try and review this asap but I might be a little while since it's a big one. |
ff352bd to
f1c46fa
Compare
|
Thanks for putting this together 🙏
The overall direction is spot on. The mechanical extraction looks clean and consistent (the A few things I'd like us to sort before merging, then some follow-up notes. Things to fix in this PR1. Duplicate lint workflows. We've now got two workflows linting the same things on PRs:
So core clippy and both JS lints run twice per PR, across two files, with slightly different invocations. On top of that, the step labelled 2. Redundant Cargo exclude. Excluding exclude = [
"crates/node-litesvm",
"crates/node-litesvm-web3js", # no Cargo.toml, can drop this
"crates/node-litesvm/tests/clock-example",
]Minor, but might as well tidy it. VersioningFor now I'm happy to keep all three packages pinned to the same version and publish them together, then let them diverge over time as needed. A core bump will always force a wrapper bump anyway (patch/minor/major), so lockstep is a fine starting point. We can revisit per-package release logic once they actually need to move independently. Follow-up (not blocking this PR)On the dependency model: right now both wrappers take their SDK as a hard Lmk what you think, and give me a shout once CI is green and I'll do another pass. 🙂 |
|
2dbef40 to
2883343
Compare
5d43799 to
c0de53f
Compare
web3js and Kit can be optionally imported through split exports, with clear peerDependency requirements (consumers using
litesvm-web3jsneed not install@solana/kit).With this PR:
node-litesvm->node-litesvm-core(JS packagelitesvm-core)node-litesvmis now the Kit wrapper (JS packagelitesvm)node-litesvm-web3jsas web3js wrapper (JS packagelitesvm-web3js)