fix(match2): handle missing first side in identityv matchsummary#7453
Open
fix(match2): handle missing first side in identityv matchsummary#7453
Conversation
Initialize scoreDetails only if firstSide is valid.
hjpalpha
reviewed
May 1, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
could it cause issues if scoreDetails is nil?
Initialize scoreDetails as an empty table and update condition to check if firstSide is not empty.
Collaborator
Author
Didn't crash, but added fix just in case |
hjpalpha
approved these changes
May 1, 2026
ElectricalBoy
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reported on discord:
https://discord.com/channels/93055209017729024/268719633366777856/1499690194662850752
How did you test this change?
Firstly tested in dev then applied hot fix live