Fix config file allowing partial overrides for judge/synthetic_user#61
Merged
Conversation
The judge: and synthetic_user: sections in mcprobe.yaml now allow
partial overrides. Previously they required provider and model fields
even when the user just wanted to set extra_instructions.
Changes:
- Add FileLLMConfigOverride model with all optional fields
- Use FileLLMConfigOverride for judge/synthetic_user in FileConfig
- Add _apply_file_override method for partial config application
- Export FileLLMConfigOverride from config package
- Update tests to use new model
This allows configs like:
```yaml
llm:
provider: ollama
model: llama3.2
judge:
extra_instructions: |
Custom judge instructions...
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
judge:andsynthetic_user:sections inmcprobe.yamlrequiredproviderandmodelfields, even when the user just wanted to addextra_instructionsand inherit everything else from the sharedllm:config.Error:
Solution
Added
FileLLMConfigOverridemodel with all optional fields, similar toScenarioLLMOverride. This allows partial overrides in the config file.Example
Now this works:
Test plan