Remove unreliable 1Password postStartCommand check#10
Merged
Conversation
The strict IFS=$'\n\t' setting was preventing proper iteration over space-separated strings for 1Password domains. This caused the firewall script to try resolving all domains as a single concatenated string instead of individual domains. Changed to use bash arrays for subdomain and TLD lists, which work correctly regardless of IFS settings. Fixes: - my.1password.com and other 1Password domains not being resolved - op vault list hanging due to blocked network connections - All 1Password API endpoints now properly allowlisted
The postStartCommand check for 1Password was giving false warnings even when 1Password was properly authenticated. This was due to environment variable handling differences in the shell context where postStartCommand runs. Since the setup-1password.sh script already provides clear feedback during postCreateCommand, and users can easily verify with 'op whoami' if needed, the postStartCommand check adds more confusion than value. Removed from both the main devcontainer.json and the template version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the 1Password verification from
postStartCommandas it was giving false warnings.Problem
The
postStartCommandwas runningop vault listto verify 1Password authentication, but it consistently showed a warning even when 1Password was properly configured and working:op whoamiandop vault listworked fine when run manually in the terminalRoot Cause
The shell context where
postStartCommandruns has different environment variable handling than interactive shells. EmptyOP_CONNECT_HOSTandOP_CONNECT_TOKENvariables interfere with the service account token, even thoughsetup-1password.shattempts to unset them.Solution
Remove the
postStartCommandverification entirely. Thesetup-1password.shscript already provides clear feedback duringpostCreateCommand, and users can verify authentication withop whoamiif needed.Changes
postStartCommandfrom.devcontainer/devcontainer.jsonpostStartCommandfrom template version insrc/liquescent-devcontainer/.devcontainer/devcontainer.jsonImpact
op whoamimanually if needed