feat(decisions): add read-only judgment retrieval - #121
Merged
lipluscodex merged 1 commit intoAug 23, 2026
Conversation
judgment 専用の検索・完全一致取得・型付き関係探索を core API と optional MCP adapter に追加する。 active/archived と repository namespace の絞り込み、cycle-safe な決定順、read-only schema と全永続表の不変性を検証する。 Tests: 280 unittest tests; MCP schema validation; eval smoke
lipluscodex
commented
Aug 23, 2026
lipluscodex
left a comment
lipluscodex
left a comment
Member
Author
There was a problem hiding this comment.
自己レビュー: PASS
Issue #120 の受入条件に照らして、PR diff、CI、実データ probe を確認しました。
- core / MCP に
search_judgments、get_judgment、traverse_judgmentsが追加されている - active 既定、archived 明示、repository namespace、exact ID、方向・relation type・有限 hop の契約がある
- traversal は cycle-safe かつ hop / stable ID 基準で決定的である
- MCP 三 tool は read-only / non-destructive / idempotent annotation と strict schema、既存 error envelope を持つ
- 既存
search、feedback、write_judgmentの契約を維持している - 全 persistent table の成功時・失敗時不変性を core / MCP test で検証している
- 実際の86 judgment入りDBの一時コピーでも三操作を実行し、実行前後のSQLite SHA-256一致を確認した
- 実装済み local stdio 範囲と、未実装のWiki生成・共有・remote/on-premを文書上で分離している
commit 5955518 で CI / Optional MCP adapter は成功し、全280 tests と schema検証、eval smokeが成功しています。ブロッキング指摘はありません。
lipluscodex
deleted the
120-featdecisions-add-read-only-judgment-retrieval
branch
August 23, 2026 01:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120
judgment 専用の read-only core API と optional MCP tools を追加し、active / archived、repository namespace、exact get、有限 hop traversal を実装しました。
通常 search / feedback / write_judgment の既存契約を保ち、成功・失敗時の全永続表不変、strict schema、stdio routing をテストしています。