Skip to content

Harden guarded proxy access and process cleanup - #559

Merged
Linuxuser67 merged 7 commits into
mainfrom
security/harden-guarded-proxy-and-process-groups-20261029
Oct 29, 2026
Merged

Linuxuser67 merged 7 commits into
mainfrom
security/harden-guarded-proxy-and-process-groups-20261029

Conversation

@Linuxuser67

Copy link
Copy Markdown
Owner

Summary

  • Require a random per-run Basic credential on the loopback SSRF-guard proxy; pass its credential-bearing URL only through child proxy environment variables, not logged argv.
  • Avoid signalling a potentially recycled process-group ID after the direct child has been reaped.
  • Bound yt-dlp impersonation-probe output and drain time, retaining child ownership across the process timeout.
  • Add regression coverage for unauthenticated proxy requests, authenticated private-target rejection, and guarded argv validation.

Independent review

Verified the missing proxy authentication and both post-reap signalling paths in gallery_probe.rs and video_tools.rs. The changes preserve the private-address filtering and make process-group signals only while the probe child is still owned and unreaped.

Rust/GTK compilation and tests are delegated to CI; the local environment does not provide the repository's GTK 4.22 / libadwaita 1.9 development packages.

@Linuxuser67
Linuxuser67 merged commit 511c327 into main Oct 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant