Repository navigation
fix(ui): read and parse torrents off the GTK thread - #556
Merged
Merged
Conversation
added 2 commits
October 28, 2026 14:24
Move torrent archive hashing into the restore blocking pool, dedupe the read+parse closure behind torrent::load_torrent_file, and log JoinError payloads instead of dropping them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
.torrentread+parse intogio::spawn_blockingat all three UI-entry sites, matching the convention already used by the enqueue path (download.rs:1027).wire_torrent_picker: was reading (≤10 MB) and parsing insideglib::spawn_future_local.handle_open_files: read was already off-thread, buttorrent_file_listran on the main loop after the await.intake_remote_torrent: same parse-on-main-loop after the remote fetch (not flagged by the review, same class).No behavior change: same picker-vs-enqueue decision, same error messages, and the exact bytes that parsed are the bytes handed to the picker/enqueue.
Found while verifying a review finding. That review also claimed
resolve_gallery_authruns on the GTK thread viadual_probe; it does not —dual_probeis spawned withtokio_rt().spawnatinline_add.rs:359, so no change was made there.