Repository navigation
Download video parts through the yt-dlp binary - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TikTok direct downloads 403 because the crate's download stack cannot send what the CDN requires: its HttpHeaders has four fields (no Referer), unknown extractor headers are dropped at deserialization, and there is no cookie channel (the extraction jar is gone with the process). Upstream yt-dlp works because extraction, cookies and headers stay in one process — confirmed against the #9997 thread and tiktok.py's per-format Referer.
This moves split-part downloads onto the binary, keeping the crate for brains (selection, planning) and using the binary for transport:
Tests: argv pinning (flags, -f/-o, trailing -- + page, cookies/UA passthrough), fallback matrix, unavailability detection, plus fake-binary integration proving spawn, progress reporting and the stale-id fallback retry end to end. 209 passing, clippy clean.