Repository navigation
Muxed adoption honors the requested height - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x.com downloads landed on the lowest quality in every path: with no pin the muxed adoption took the crate's best_audio_video_format, which is first-in-extractor-order (x.com lists ascending) and ignores the quality cap entirely — and a stale pin degraded into the same fallback.
select_muxed_format replaces it: smallest muxed height at or above the cap, else the tallest (same semantics as the HLS preset). Only directly fetchable files qualify, so DRM/link-less entries can't shadow a playable one. Together with the dialog writing the picked height into quality, a dropped pin now degrades to the chosen height instead of the lowest listing.
Tests: height-cap matrix (best/1080p/720p/480p over ascending muxed listings) plus updated adopt/stale-pin expectations; negative-controlled against the old first-in-order pick. 203 passing, clippy clean.