Skip to content

Staging cleanup on remove, yt-dlp -- separator, HLS candidate sort - #41

Merged
Linuxuser67 merged 1 commit into
mainfrom
fix-staging-hls
Sep 18, 2026
Merged

Linuxuser67 merged 1 commit into
mainfrom
fix-staging-hls

Conversation

@Linuxuser67

Copy link
Copy Markdown
Owner

Follows the audit of the yt-dlp surface:

  • remove() now drops staging_dir(id) for video rows via the guarded clean_staging helper (previously prod-unused). Pause/cancel keep staging for resume; live rows are exempt since their worker was only signaled and finalizes itself. delete_download is covered through remove().
  • Both yt-dlp page-URL argv sites (fetch_video_page, run_hls_ytdlp) now end options with -- before the URL. ffmpeg -i sites need none (flag values).
  • select_hls_format sorts candidates ascending, so the height cap genuinely picks smallest-at-or-above regardless of extractor order (serves the VOD preset and the live path alike).

Tests: remove() cleans video staging, exempts live rows, leaves plain rows alone; HLS selection ignores extractor order (negative-controlled: fails without the sort). 202 passing, clippy clean.

@Linuxuser67
Linuxuser67 merged commit 346fc4e into main Sep 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant