Repository navigation
Bound handoff body reads, separate manifests, split worker - #45
Merged
Merged
Conversation
Linuxuser67
commented
Oct 27, 2026
Linuxuser67
commented
Owner
Address the v1.6.3 review's required items: - verifyGrab/grabStatus now read the JSON body under the same AbortController deadline as the fetch, so a listener that sends headers and stalls the body can no longer hold pairing verification (and the download's deciding guard) open. A malformed/stalled body is unverified; an unreachable port is still down. - mergeVideoFinds keys each manifest by its own path. Two same-protocol manifests in one directory no longer collapse into one menu entry. A folder with exactly one HLS and one DASH manifest still pairs them as protocol alternates, and direct renditions attach only when the folder holds a single family. - Split background.js into handoff.js (pairing, cookies, handoff, explicit sends, status), intercept.js (download interception), and video-menu.js (detection, menu, tab listeners). background.js keeps the shared helpers and runtime dispatcher. Chrome loads siblings via importScripts; Firefox lists them before background.js. Nits: remove the unreachable "unpaired" options branch, drop the duplicate pairing-code regex check, return the fitted cookie count instead of re-parsing the body, and move the test-only handOff helper into the test loader. Add tests for a stalled body, same-directory manifests, query-string variants, and multi-family direct renditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.