Skip to content

Show accurate pairing verification status - #44

Merged
Linuxuser67 merged 12 commits into
mainfrom
fix/accurate-pairing-verification-status
Oct 24, 2026
Merged

Linuxuser67 merged 12 commits into
mainfrom
fix/accurate-pairing-verification-status

Conversation

@Linuxuser67

@Linuxuser67 Linuxuser67 commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Replace the Options page's optimistic "Paired" label with distinct Saved, Verifying, Verified, Unverified, and unavailable states.
  • Only show Verified after the background worker successfully performs its existing nonce/HMAC handshake with Grab.
  • Make cookie permission status explicit and separate from cryptographic verification.
  • Ignore stale verification responses when the code is edited, and avoid overwriting early user input while the initial storage read is pending.
  • Move Grab's runtime status into the popup header between the title and Options gear, using a compact status dot, theme-aware colors, and accessible live status text.

Independent review

  • Checked that the UI never treats code format or storage alone as proof of pairing.
  • Checked status handling for wrong keys, an unavailable Grab server, unknown cookie permission state, input edits during a pending handshake, and the initial storage-read race.
  • Added regression tests for pairing status transitions and popup header placement.

Validation

  • JavaScript syntax check: passed.
  • Firefox manifest synchronization check: passed.
  • Node test suite: passed (including new pairing-status and popup-header regressions).
  • CI run.

@Linuxuser67
Linuxuser67 merged commit 4bb1ead into main Oct 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant