feat(ccu): integrate internal collective backend - #76
Draft
Kur0x wants to merge 2 commits into
Draft
Conversation
This was referenced Jul 28, 2026
Closed
Chand1erLiu
reviewed
Jul 28, 2026
|
|
||
| auto *comm = static_cast<TileXR::TileXRComm *>(request.comm); | ||
| TileXR::TileXRCcuBackend *backend = comm->GetCcuBackendForCollectives(); | ||
| if (backend == nullptr || !backend->Available()) { |
Contributor
There was a problem hiding this comment.
In production this condition is always true for a forced CCU request: none of the normal TileXRComm initialization paths call InitCcuBackend; the only caller is EnableCcuBackendForTest. Consequently the newly public TILEXR_COLLECTIVE_BACKEND_CCU option always returns TILEXR_ERROR_NOT_INITIALIZED. Please initialize the backend in the normal communicator lifecycle or lazily before dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
5 of 9. Depends on
codex/ccu-stack-04-runtime.Validation
git diff --checktests/comm/unit/test_tilexr_source_guards.cppTileXR source guard checks passedScope
Host-only validation. Hardware smoke is not rerun in this PR.