perf(moonep): replace reduce grad with owner pull - #121
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 277a9e26cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2c6b9ed4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Post-Merge Validation
Validation was rerun after conflict resolution and rebasing onto the latest
main.Validated Revisions
c2c6b9ed4e123c7d18d612547a18a1ee87430c84main:7c15324247c1b54190d9fb6b11a79b8096e1ea721c3d6d7972ae3c54c04a24695961f584015b0a15main.git diff --check origin/main...HEADpassed.Build and Host Validation
The same source snapshot was synchronized to:
root@141.61.53.106root@141.61.53.110/tmp/TileXR-pr121-verify-20260813-c2c6b9e930bce692efdc2f57489769ce0182dce8f457a4d0b6207032271a3b55d07b2ebBoth Ascend950 hosts successfully rebuilt and installed the pure AICore
ReduceGrad implementation.
f1971eeb6412e0cd65f55b12382fbf78a5fd1c017a818287f1673522b456103e.106CTest:33/33 passed.110focused ReduceGrad CTest:3/3 passed239 passed7/7 passed88 passed, 2 subtests passedpy_compile.$ORIGIN.libascend_hal.soresolves from the real driver HAL directory.Four-Rank Ascend950 Correctness
The exact correctness smoke used four physical Ascend950 devices, ranks 0-3,
with
torch_npu 2.7.1.post4.dev20260417.Confirmed behavior:
8388608bytes.203423744bytes.1588.75/1598.62 us.Artifact:
/tmp/TileXR-pr121-verify-20260813-c2c6b9e/artifacts/pr121-exact-default8m/summary.jsonSHA256:
ffe61438b8cb1f73980e04d1d90813cbac1f5e9e809bdd6e7ba4f5f34ae1086fThe three smoke samples are correctness evidence and are not treated as a
formal performance run.
Post-Merge Performance Regression Check
A short
5 warmup + 20 measuredfour-rank performance run produced:1539.76 us1583.39 us1536.22-1562.40 us1595.37-1662.54 usThe post-merge result is within or better than the previously retained TileXR
range, so no ReduceGrad performance regression was observed after conflict
resolution.
Artifact:
/tmp/TileXR-pr121-verify-20260813-c2c6b9e/artifacts/pr121-perf-5x20/summary.jsonSHA256:
1452ccca346ebf21c3affef39ff1ac1617480e7936bdb8ebd1a4d17784ea6ecfReview Disposition
Review findings outside the normal MoonEP ReduceGrad performance path were
recorded but intentionally not changed in this PR. These include malformed
single-rank device state, asymmetric fault injection, error teardown,
unreleased ABI compatibility, and overlapping direct C API calls from
different streams.
The supported Torch/MoonEP path prevents overlapping ReduceGrad launches at
the runtime level, binds each buffer to one NPU stream, and allows reuse only
after synchronization. Its focused reentrancy test passed.
Validation Boundaries
performed.
environmental baseline was not triggered.
torch_npubuilds. A strict same-runtime native rebuild followed by threeinterleaved
20 warmup + 50 measuredA/B runs remains the next validationstep before treating the native performance comparison as final.