Skip to content

fix: allow curl downloads with untrusted certificates - #116

Merged
chaowick merged 1 commit into
mainfrom
codex/curl-insecure-downloads
Aug 12, 2026
Merged

fix: allow curl downloads with untrusted certificates#116
chaowick merged 1 commit into
mainfrom
codex/curl-insecure-downloads

Conversation

@Kur0x

@Kur0x Kur0x commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary

  • pass -k to the open-source dependency downloader
  • apply the same curl TLS behavior to CANN package downloads
  • apply the same curl TLS behavior to GitHub Actions runner provisioning

Validation

  • bash -n scripts/download_open_source_deps.sh scripts/cann_download_install.sh scripts/ci/provision/runner.sh
  • python3 -m unittest tests.ci.test_control_contract (53 tests)
  • git diff --check

@Kur0x
Kur0x requested a review from a team as a code owner August 11, 2026 12:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 956601c8e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/ci/provision/runner.sh
Comment thread scripts/cann_download_install.sh
@chaowick
chaowick merged commit 8d22775 into main Aug 12, 2026
2 of 5 checks passed
@Kur0x
Kur0x deleted the codex/curl-insecure-downloads branch August 12, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants