fix(release): verify rong_crypto with an engine feature - #48
Merged
Merged
Conversation
cargo publish for modules must pass --features quickjs so rong::JSContext exists. rong_crypto was added to the crate list but not to that verify set, so its first publish failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish Packages failed on
rong_crypto0.6.0:cargo publishverified it with no engine feature, sorong::JSContextwas missing.Add
rong_cryptotoneeds_engine_verify_featuresso it gets--features quickjslike the other modules.Already on crates.io from the failed run (will skip on retry):
rong_typegen0.6.1rong_core0.6.1rong_abort0.6.1rong_http0.6.1@rongjs/rong0.6.1Still unpublished:
rong_crypto0.6.0,rong_modules0.6.1.After merge, re-run Publish Packages from
masterwithpackage_scope=rust,rust_selection=--changed,package_tags=always.