Engine: encapsulate termination in the correctness proofs#28
Open
Engine: encapsulate termination in the correctness proofs#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
matchresand instead I am just returning a bogus result for an unfinished match. But since the fuel is always enough, we know we terminated with a correct result. This small change makes using functional versions more convenient.Previously the correctness theorem for the functional version said "if the match terminates, then the result is correct". But the match always terminates, so this removes this precondition.
I modified the complexity proofs to remove the precondition of being a pike_regex. For those that are not a pike regex, the engine immediately exits. This change is not strictly needed, if preferred, I can revert it and put a
pike_regexrequirement on the correctness of the functional engines.