fix Bug : lose generation result if leave gen space#86
Open
Omar AbdElzaher sleam (omar92) wants to merge 1 commit intoLightricks:mainfrom
Open
Conversation
Replace conditional rendering with class-based visibility for the 'GenSpace' and 'VideoEditor' components, This fix the bug of losing the generation if swapped taps while something is generating
Omar AbdElzaher sleam (omar92)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace conditional rendering with class-based visibility for the 'GenSpace' and 'VideoEditor' components, This fix the bug of losing the generation if swapped taps while something is generating
#85
Fixed. GenSpace no longer unmounts when you switch to Video Editor, so in-progress generation state remains alive and visible when you come back.
What changed:
Updated Project.tsx to keep both tab components mounted and toggle visibility with hidden instead of conditional mount/unmount.
Why this fixes it:
Before: tab switch destroyed GenSpace state (useGeneration state, progress UI, completion handlers).
Now: GenSpace stays mounted, so generation progress/result handling continues even while you’re on editor tab.