fix(ci): add dedicated lint workflow and fix mypy errors#124
Merged
Conversation
Linting now runs in its own workflow (lint.yml) on a single Python version in parallel with the test matrix, rather than being mixed into tests. Also fixes the mypy errors that would have caused the new workflow to fail on its first run: - Split rocrate.* and astra.* mypy overrides; follow_untyped_imports only on astra.* (applying it to rocrate.* caused no-untyped-call cascades) - Add ignore_missing_imports for daytona_sdk and dotenv (eval-only deps not installed in the dev group) - commands.py: type: ignore[misc] on astra_init.callback() — Click types callback as Optional[Callable] but it is always set at decoration time - eval/build.py: rename result -> dirty to fix CompletedProcess[bytes] vs CompletedProcess[str] type mismatch Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lightcone-cli | 68707cc | Commit Preview URL Branch Preview URL |
May 13 2026, 11:54 AM |
❌ Eval Results
GradersNo grader results Full output |
Developer Certificate of OriginThis PR has been approved. Before it can be merged, all contributors must sign the Developer Certificate of Origin. StatusHow to signPost the following comment exactly as written:
|
Member
Author
|
I have read the Developer Certificate of Origin and I hereby sign the DCO for this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lint.ymlworkflow: runsruff check src/ tests/andmypy src/on Python 3.13, in parallel with the test matrix, skipped on draft PRs. Linting was previously absent from CI.pyproject.toml: splitrocrate.*andastra.*into separate mypy overrides —follow_untyped_imports = trueonly onastra.*(applying it torocrate.*causedno-untyped-callcascades inwrroc.py); added override fordaytona_sdkanddotenvwhich are eval-only deps not installed in the dev group.commands.py:# type: ignore[misc]onastra_init.callback()— Click typescallbackasOptional[Callable]but it is always set at decoration time.eval/build.py: renamedresult→dirtyto fixCompletedProcess[bytes]assigned to a variable typed asCompletedProcess[str].Both
ruff check src/ tests/andmypy src/pass cleanly locally before this PR.Test plan
Lintworkflow appears and passes on this PRruffstep passesmypystep passes🤖 Generated with Claude Code