Skip to content

fix(ci): don't run expensive workflows on draft PRs#123

Merged
aboucaud merged 3 commits into
mainfrom
fix/skip-draft-prs
May 13, 2026
Merged

fix(ci): don't run expensive workflows on draft PRs#123
aboucaud merged 3 commits into
mainfrom
fix/skip-draft-prs

Conversation

@aboucaud
Copy link
Copy Markdown
Member

@aboucaud aboucaud commented May 8, 2026

Summary

  • claude-code-review: added if: github.event.pull_request.draft == false — Claude review shouldn't run on work in progress
  • eval: added draft guard while preserving workflow_dispatchif: github.event_name == 'workflow_dispatch' || github.event.pull_request.draft == false
  • tests: added draft guard (if: github.event_name == 'push' || github.event.pull_request.draft == false); also migrates from pip install + actions/setup-python to uv sync + astral-sh/setup-uv (consistent with the rest of CI); adds Python 3.13 to the test matrix

Test plan

  • Open a draft PR and confirm none of the three workflows trigger
  • Mark the PR ready for review and confirm all three run

🤖 Generated with Claude Code

Signed-off-by: Alexandre Boucaud aboucaud@apc.in2p3.fr

Claude code review and eval are expensive and should not run on work
in progress. Tests are also skipped on drafts to save CI minutes.

- claude-code-review: if: draft == false
- eval: if: workflow_dispatch OR draft == false
- tests: if: push OR draft == false; also migrates from pip/setup-python
  to uv, and adds Python 3.13 to the test matrix

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 8, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
lightcone-cli 7bfd9bf Commit Preview URL

Branch Preview URL
May 13 2026, 11:56 AM

@aboucaud aboucaud requested a review from EiffL May 8, 2026 08:49
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

❌ Eval Results

Metric Value
Score 0.00
Build complete
Cost $0.00
Turns 0
Duration 0s
lightcone-cli 0.3.5.dev16+g9ccaf0ada (9ccaf0ad)
Results Download

Graders

No grader results

Full output
11:54:10 lightcone.eval.build Building lightcone-cli wheel from /home/runner/work/lightcone-cli/lightcone-cli ...
11:54:14 lightcone.eval.build Built lightcone_cli-0.3.5.dev16+g9ccaf0ada-py3-none-any.whl (commit 9ccaf0ad)
11:54:17 lightcone.eval.harness Trial build-snae-0 failed: Failed to create sandbox: Invalid credentials
Traceback (most recent call last):
  File "/home/runner/work/lightcone-cli/lightcone-cli/src/lightcone/eval/harness.py", line 112, in run_trial
    sandbox.create()
  File "/home/runner/work/lightcone-cli/lightcone-cli/src/lightcone/eval/sandbox.py", line 149, in create
    self._sandbox = self._daytona.create(
                    ^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/lightcone-cli/lightcone-cli/.venv/lib/python3.12/site-packages/daytona_sdk/_utils/errors.py", line 181, in sync_wrapper
    process_n_raise_exception(e)
  File "/home/runner/work/lightcone-cli/lightcone-cli/.venv/lib/python3.12/site-packages/daytona_sdk/_utils/errors.py", line 139, in process_n_raise_exception
    raise create_daytona_error(
daytona_sdk.common.errors.DaytonaAuthenticationError: Failed to create sandbox: Invalid credentials
  snae trial 0: score=0.00 error: Failed to create sandbox: Invalid credentials

lightcone-cli: 0.3.5.dev16+g9ccaf0ada (HEAD 9ccaf0ad)
ASTRA: 0.2.9

  Eval Results: Scores  
┏━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Task ┃     Score     ┃
┡━━━━━━╇━━━━━━━━━━━━━━━┩
│ snae │ 0.00 +/- 0.00 │
│      │  pass@k: 0%   │
│      │   1 errors    │
└──────┴───────────────┘

   Eval Results: Cost &   
         Duration         
┏━━━━━━┳━━━━━━━━━━━━━━━━━┓
┃ Task ┃ Cost / Duration ┃
┡━━━━━━╇━━━━━━━━━━━━━━━━━┩
│ snae │      $0.00      │
│      │       0s        │
└──────┴─────────────────┘

Total: 1 trials, $0.00, 0s

Results saved to: eval-results/build-9ccaf0ad/results.json

Copy link
Copy Markdown
Member

@EiffL EiffL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Developer Certificate of Origin

This PR has been approved. Before it can be merged, all contributors must sign the Developer Certificate of Origin.

Status

How to sign

Post the following comment exactly as written:

I have read the Developer Certificate of Origin and I hereby sign the DCO for this PR

@EiffL
Copy link
Copy Markdown
Member

EiffL commented May 8, 2026

Thanks alex for saving some of my hard earned $$$ :-)

@aboucaud
Copy link
Copy Markdown
Member Author

aboucaud commented May 8, 2026

I have read the Developer Certificate of Origin and I hereby sign the DCO for this PR

@aboucaud aboucaud merged commit ec4dc72 into main May 13, 2026
4 of 8 checks passed
@aboucaud aboucaud deleted the fix/skip-draft-prs branch May 13, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants