Manual docs improvement before final release#120
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lightcone-cli | 2e548cb | Commit Preview URL Branch Preview URL |
May 12 2026, 10:26 PM |
❌ Eval Results
GradersNo grader results Full output |
Member
|
@aboucaud Nice! I guess I'll just put my nersc intro into this branch. |
Member
|
Looking good guys :-) Note that the NERSC docs do not use |
Reorganized away from the now-removed docs/hpc/ tree and into the new docs/user/ user-guide structure. The page is a focused, site- specific walkthrough: install Claude Code → pick a Python env (with the 40 GB home-quota → \$SCRATCH symlink note) → install lightcone-cli from PyPI or source → init a project → run on compute nodes via salloc + claude. Wired into the User Guide nav as "NERSC (Perlmutter)" right after "Running on a Cluster" (which it complements with site-specific overlays), and cross-linked from cluster.md so NERSC users land here naturally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1a58132 to
29bec15
Compare
Bring the NERSC guide in line with the conventions of the improved install.md (uv recommended, pip as fallback) and tighten the prose: - §1 Python: lead with the uv install one-liner + \`uv python install 3.12\`. NERSC's \`module load python\` is now the alternative inside a !!! note, with the conda-env subsection nested under it (only relevant if you went the module route). - §2 Install: \`uv tool install lightcone-cli\` is the headline command. The pip path is preserved as a !!! note alternative with === "NERSC python module" / === "Conda env" tabs so users only see the variant relevant to their Python choice. Source install commands switched to \`uv pip install -e\`. "One-time setup" + "Verify" merged into a single short block. - §7 Updating: added a \`uv tool upgrade\` tab as the default; pip and source as alternatives. - §8 Uninstalling: symmetric uv-tool / pip tabs. - Drops the stale reference to \`~/.lightcone/targets/\` (folder no longer exists; only config.yaml lives there). The blockquote-style callouts converted to !!! note / !!! warning / !!! danger admonitions throughout, matching the vocabulary already used in user/index.md and user/install.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Change the nersc doc to default to uv |
Verified the doc against the actual CLI surface in src/lightcone/cli/commands.py. The canonical command list is init / run / status / verify / build / export / eval — there is no \`lc setup\`. Global config is auto-created by _ensure_global_config() on any \`lc\` invocation (commands.py:75). - §2 "One-time setup and sanity check" renamed to "Sanity check". Dropped the stale \`lc setup\` command. The pin-runtime hint moved into a !!! note that explains the auto-creation, matching how install.md §3 frames it. - §5 sbatch example: now leads with \`export PATH=\$HOME/.local/bin\` (the uv tool install default), with conda activation commented as the alternative. Previously assumed a conda env, which is inconsistent with the uv-first install path in §1/§2. Other commands and flags in the doc were verified to exist: - lc init --scratch (commands.py:137) - lc run -j / --jobs (commands.py:382) - lc build → podman-hpc build + migrate (container.py:558,635) - <project>/.lightcone/lightcone.yaml + scratch_root (scratch.py:8,67) - /lc-new and /lc-migrate skills (claude/lightcone/skills/) The troubleshooting table entry about \`resolve_analysis_tree\` ImportError was reproduced live against the venv's astra-tools, so it stays. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…gent lightcone-cli is designed to work with any agent-based CLI; Claude Code is currently the best-supported one, but it's not the only intended target. The earlier doc spoke as if Claude Code = the agent. - §0: rewrote the opening paragraph to make the "any agent CLI; we use Claude Code as the running example" framing explicit. The Claude install commands move under a clearly scoped "Installing Claude Code:" subsection. - §3: \`claude\` launch line now reads "launch your agent CLI (Claude Code shown here)". - §4: "Once Claude Code is open" → "Once your agent CLI is open (Claude Code in this guide's examples)". - §5 interactive runs: prose now refers to "the agent" generically; the parenthetical "(Claude Code)" is gone since the framing is set in §0. The shell command keeps \`claude\` but adds a comment "# or whichever agent CLI you use". - §5 batch runs: adjusted to "no agent CLI involved" instead of "no Claude Code in the loop" — same meaning, agent-neutral. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The §0 intro already says the choice of agent is open and Claude Code is just the running example. Concrete pointers help readers act on that — added a !!! note at the end of §0 with two examples: - OpenAI Codex (github.com/openai/codex) - opencode (opencode.ai) Each entry links to its install docs. Kept the list short and the prose neutral so the section doesn't read like an endorsement. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…acy fixes - Add narrative block population step to lc-new docs, agent-workflow, and tutorial - Add Quick Start snippet to docs/index.md researcher section - Fix commands.py annotation (setup→export) in index.md repo tree - Remove stale lc setup entry from zensical.toml nav - Replace stale Dagster reference in lc-feedback.md maintainer note - Add text/bash language tags to ~30 bare code fences across CLI reference, skills, tutorial, contributing, and user docs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Developer Certificate of OriginThis PR has been approved. Before it can be merged, all contributors must sign the Developer Certificate of Origin. Statusnone yet How to signPost the following comment exactly as written:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important things
/lc-newis new and has to be added to the docsGeneral Checklist
Content completeness
Accuracy & freshness
Links & navigation
Clarity & style
Discoverability
Legal & security