Skip to content

[CCUBE-2284] Remediate findings - #51

Merged
qroll merged 4 commits into
mainfrom
CCUBE-2284
Sep 15, 2026
Merged

qroll merged 4 commits into
mainfrom
CCUBE-2284

Conversation

@qroll

@qroll qroll commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)
  • Documentation (change to documentation, comments or API descriptions)
  • Tests (improvements to unit tests or E2E tests)
  • Other (technical improvements, refactoring, or changes that don't fall into the above categories)

Description of changes

  • Link to ticket
  • Finding 1:
    • Split the workflows so that GitLab pipeline can only be accessed through release branches (when PR is merged and approved)
    • This is done in coordination with tightened access to these branches
    • Escape GitHub parameters before usage
  • Finding 2:
    • Add a check for file name format (kebab-case)

Checklist

  • Changes follow the project guidelines in CONTRIBUTING.md
  • Updated documentation

@qroll qroll added type: bug Something isn't working type: chore For technical improvements or refactoring. labels Sep 15, 2026
ghazwan-gt
ghazwan-gt previously approved these changes Sep 15, 2026
Comment thread .github/workflows/pr-checks.yml Outdated
Comment thread .github/workflows/README.md Outdated
@qroll
qroll requested a review from ghazwan-gt September 15, 2026 08:47
@qroll
qroll merged commit 48c798b into main Sep 15, 2026
5 of 6 checks passed
@qroll
qroll deleted the CCUBE-2284 branch September 15, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working type: chore For technical improvements or refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants