Skip to content

[MOL-22399][FN] fix menu section style #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qroll merged 3 commits into from
Sep 29, 2026
Merged

[MOL-22399][FN] fix menu section style #1489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ca86ee
[MOL-22399][FN] fix menu section style
fauzannaufan-gws Sep 28, 2026
afd2752
[MOL-22399][FN] address PR comments
fauzannaufan-gws Sep 29, 2026
09e9e9c
[MOL-22399][RL] Reorder styles
qroll Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/menu/menu-section.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ export const GRID_COLUMN_GAP_PX = 8;
export const section = css`
padding: ${Spacing["spacing-8"]} 0;
margin: 0;
list-style: none;
`;

export const sectionWithDivider = css`
border-top: ${Border["width-010"]} ${Border["solid"]} ${Colour["border"]};
`;
Expand All @@ -25,7 +25,11 @@ export const label = css`
color: ${Colour["text-subtler"]};
`;

export const columns = css`
export const list = css`
list-style: none;
`;

export const listColumns = css`
${gridTokens.rows}: initial;

display: grid;
Expand Down
2 changes: 1 addition & 1 deletion src/menu/menu-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export const MenuSection = ({
ref={ulRef}
data-testid={testId}
aria-labelledby={internalId}
className={clsx(columns && styles.columns)}
className={clsx(styles.list, columns && styles.listColumns)}
{...otherProps}
>
{children}
Expand Down
Loading