Skip to content

[MISC][XY] Update semantic token mapping - #1477

Merged
qroll merged 4 commits into
masterfrom
update-dark-mode-tokens
Sep 23, 2026
Merged

qroll merged 4 commits into
masterfrom
update-dark-mode-tokens

Conversation

@ninjasheeps

@ninjasheeps ninjasheeps commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)
  • Documentation (change to documentation, comments or API descriptions)
  • Tests (improvements to unit tests or E2E tests)
  • Other (technical improvements, refactoring, or changes that don't fall into the above categories)

Description of changes

  • Link to Figma for updated semantic token mapping (click on Variables to see dark mode)
  • Update semantic token mapping to align with figma
  • Add missing semantic tokens

Checklist

  • Changes follow the project guidelines in CONTRIBUTING.md and CONVENTIONS.md
  • Looks good on mobile and tablet
  • Updated documentation
  • Added/updated unit tests
  • Added/updated E2E tests

@ziggyzet ziggyzet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update the screenshots for the e2e test due to the color changes

Comment thread src/theme/styles/presets/semantic-colours/dark-default.css
@qroll qroll added the type: enhancement New feature or request label Sep 22, 2026
@qroll qroll added this to the v4.0.0-alpha.13 milestone Sep 23, 2026
@qroll
qroll merged commit 282593e into master Sep 23, 2026
12 checks passed
@qroll
qroll deleted the update-dark-mode-tokens branch September 23, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants