Skip to content

[MOL-22452][TP] fix asgard-0002, bind Playwright server to loopback … - #1475

Merged
qroll merged 2 commits into
masterfrom
MOL-22452
Sep 18, 2026
Merged

qroll merged 2 commits into
masterfrom
MOL-22452

Conversation

@thanhpt0105-gt

@thanhpt0105-gt thanhpt0105-gt commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

…and remove host networking

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)
  • Documentation (change to documentation, comments or API descriptions)
  • Tests (improvements to unit tests or E2E tests)
  • Other (technical improvements, refactoring, or changes that don't fall into the above categories)

Description of changes

Checklist

  • Changes follow the project guidelines in CONTRIBUTING.md and CONVENTIONS.md
  • Looks good on mobile and tablet
  • Updated documentation
  • Added/updated unit tests
  • Added/updated E2E tests

Screenshots

@thanhpt0105-gt thanhpt0105-gt self-assigned this Sep 18, 2026

@qroll qroll left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the npm run test-e2e-ci command doesn't work on my machine after this change

does it work for you?

0.0.0.0 is required inside the container for Docker bridge traffic
to reach the server. Security is enforced by the host-side port
mapping (127.0.0.1:3010:3010) which restricts access to loopback.
@qroll qroll added the type: bug Something isn't working label Sep 18, 2026
@qroll qroll added this to the v4.0.0-alpha.13 milestone Sep 18, 2026
@qroll
qroll merged commit 9e0a4b0 into master Sep 18, 2026
12 checks passed
@qroll
qroll deleted the MOL-22452 branch September 18, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants