Navbar submenu items grid - #1474
fauzannaufan-gws wants to merge 22 commits into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
feef61f to
70f496e
Compare
|
Tried adding a label to a |
|
What is the expected grid placement behaviour and navigation order? Currently, items will be arranged by row The linked Figma shows items being arranged in alphabetical order by column, though Screen.Recording.2026-09-21.at.2.24.39.PM.mov |
|
You're right, the items should be arranged by column first according to Figma. Thanks for noticing this! Edit: changed the grid placement behavior |
70f496e to
9ba40ab
Compare
34897f7 to
f4282fb
Compare
| className | ||
| )} | ||
| > | ||
| {labelElement} |
There was a problem hiding this comment.
hmm I think we can just merge this? so always render this parent section div with a ul even without columns and label; labelElement will be conditionally rendered
| ).toBe("3"); | ||
| }); | ||
|
|
||
| it("should render label outside the <ul> when both columns and label are provided", () => { |
There was a problem hiding this comment.
this is a visual outcome, so it's better to cover in the e2e tests. you can set a long label string for grid-layout-with-label.e2e.tsx, which lets us capture the wrapping behaviour in the default mount screenshot
| expect(a).toHaveFocus(); | ||
| }); | ||
|
|
||
| it("should set panel maxWidth CSS var based on max columns across child sections", () => { |
There was a problem hiding this comment.
isn't this already covered by should set panel maxWidth CSS var for 3 columns?
3 participants
Type of changes
Description of changes
Checklist
Screenshots
Screenshot is available in E2E folder