Skip to content

[MOL-22452] Remediate findings - #1468

Merged
qroll merged 6 commits into
masterfrom
MOL-22452
Sep 16, 2026
Merged

qroll merged 6 commits into
masterfrom
MOL-22452

Conversation

@thanhpt0105-gt

@thanhpt0105-gt thanhpt0105-gt commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)
  • Documentation (change to documentation, comments or API descriptions)
  • Tests (improvements to unit tests or E2E tests)
  • Other (technical improvements, refactoring, or changes that don't fall into the above categories)

Description of changes
Link to [ticket] https://sgtechstack.atlassian.net/browse/MOL-22452
Description of changes:

  • Prevent GitHub Actions script injection in trigger-gitlab-pipeline.yml by moving github.event.head_commit.message and github.ref_name from direct ${{ }} interpolation to env: block
  • Replace execSync with execFileSync in codemod CLI to prevent command injection via shell metacharacters in target path
  • Sanitize href in withNotificationBanner link attributes using DOMPurify.isValidAttribute to block javascript: and data: URLs

Checklist

  • Changes follow the project guidelines in CONTRIBUTING.md and CONVENTIONS.md
  • Looks good on mobile and tablet
  • Updated documentation
  • Added/updated unit tests
  • Added/updated E2E tests

Screenshots

Comment thread .github/workflows/trigger-gitlab-pipeline.yml Outdated
Comment thread src/notification-banner/notification-banner-hoc.tsx Outdated
@qroll qroll added the type: bug Something isn't working label Sep 15, 2026
@qroll qroll changed the title Mol 22452 [MOL-22452] Remediate findings Sep 16, 2026
Comment thread src/notification-banner/notification-banner-hoc.tsx Outdated
@qroll qroll added this to the v4.0.0-alpha.13 milestone Sep 16, 2026
@qroll
qroll merged commit c6d9dd2 into master Sep 16, 2026
12 checks passed
@qroll
qroll deleted the MOL-22452 branch September 16, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants