Skip to content

[CCUBE-2188][GZ] refactor file upload - #1426

Merged
qroll merged 26 commits into
masterfrom
CCUBE-2188/fileupload
Sep 18, 2026
Merged

[CCUBE-2188][GZ] refactor file upload#1426
qroll merged 26 commits into
masterfrom
CCUBE-2188/fileupload

Conversation

@ghazwan-gt

@ghazwan-gt ghazwan-gt commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)
  • Documentation (change to documentation, comments or API descriptions)
  • Tests (improvements to unit tests or E2E tests)
  • Other (technical improvements, refactoring, or changes that don't fall into the above categories)

Description of changes

  • Link to ticket
  • Link to Figma
  • Merged FileListItem (display/error) and FileItemEdit (edit) into a single unified component that manages its own mode internally
  • Reduced code complexity by extracting shared logic into reusable pieces
  • Simplified the parent FileList by removing mode-tracking state and replacing it with a simple predicate
  • Consolidated two separate style files into one

Checklist

  • Changes follow the project guidelines in CONTRIBUTING.md and CONVENTIONS.md
  • Looks good on mobile and tablet
  • Updated documentation
  • Added/updated unit tests
  • Added/updated E2E tests

Screenshots

Before After
image image

@ghazwan-gt ghazwan-gt self-assigned this Aug 17, 2026
@ghazwan-gt ghazwan-gt added the type: enhancement New feature or request label Aug 17, 2026
qroll
qroll reviewed Aug 18, 2026
View reviewed changes
Comment thread src/file-upload/file-list/file-list.tsx
Comment thread src/file-upload/file-list/file-list.tsx Outdated
Comment thread src/file-upload/file-list-item/file-list-item.styles.ts Outdated
Comment thread src/file-upload/file-list-item/file-item-details.tsx Outdated
Comment thread src/file-upload/file-list-item/file-item-details.tsx
Comment thread src/file-upload/file-list-item/file-list-item.tsx Outdated
Comment thread src/file-upload/file-list-item/file-list-item.tsx
Comment thread src/file-upload/file-list-item/file-list-item.tsx
Comment thread .../components/file-upload/__screenshots__/chromium/FileUpload-Long-description-text--mount.png Outdated
@qroll qroll added the type: chore For technical improvements or refactoring. label Aug 18, 2026
@ghazwan-gt
ghazwan-gt force-pushed the CCUBE-2188/fileupload branch from 03551f0 to c8b5e86 Compare August 25, 2026 08:23
@ghazwan-gt ghazwan-gt changed the title [CCUBE-2188] refactor file upload [CCUBE-2188][GZ] refactor file upload Aug 25, 2026
qroll
qroll requested changes Aug 25, 2026
View reviewed changes
Comment thread src/file-upload/file-list/file-list.tsx Outdated
Comment thread src/file-upload/file-list-item/file-list-item.tsx
Comment thread src/file-upload/file-list-item/file-list-item.tsx
qroll
qroll reviewed Aug 27, 2026
View reviewed changes
Comment thread src/file-upload/file-list/file-list.tsx
Comment thread src/file-upload/file-list/file-list.tsx
@ghazwanmuhammad
[CCUBE-2188][GZ] extract shared utils, define new types
26e756a
@ghazwanmuhammad
[CCUBE-2188][GZ] merge file list item and file item edit
03965dc
@ghazwanmuhammad
[CCUBE-2188][GZ] merge styles
4ee9ba9
@ghazwanmuhammad
[CCUBE-2188][GZ] internalize mode management
3d27231
@ghazwanmuhammad
[CCUBE-2188][GZ] update error styling
01f577d
@ghazwanmuhammad
[CCUBE-2188][GZ] simplify render item fn
ecd3d1d
@ghazwanmuhammad
[CCUBE-2188][GZ] remove grouping logic
3f99a12
@ghazwanmuhammad
[CCUBE-2188][GZ] extract styling to component style file
b3ca064
@ghazwanmuhammad
[CCUBE-2188][GZ] remove description render on error
93a9327
@ghazwanmuhammad
[CCUBE-2188][GZ] remove unnecessary lines on file item details
7fdebb2
@ghazwanmuhammad
[CCUBE-2188][GZ] inline actions
72bc9e7
@ghazwanmuhammad
[CCUBE-2188][GZ] restore comments
8201703
@ghazwanmuhammad
[CCUBE-2188][GZ] simplified parent child interaction
dd5984a
@ghazwanmuhammad
[CCUBE-2188][GZ] improve file list item
5061f9e
@ghazwanmuhammad
[CCUBE-2188][GZ] remove desktop long desc snapshot
6422291
@ghazwanmuhammad
[CCUBE-2188][GZ] bring back disable sort when any item is on edit mode
ac42019
@ghazwanmuhammad
[CCUBE-2188][GZ] consider description only when required
623de02
@ghazwanmuhammad
[CCUBE-2188][GZ] move derived state position
03b4128
@ghazwanmuhammad
[CCUBE-2188][GZ] vertically center image when no inline actions present
68cda4f
@ghazwanmuhammad
[CCUBE-2188][GZ] handles when file list items changed on edit mode
f4feebc
@ghazwanmuhammad
[CCUBE-2188][GZ] fix item not entering edit mode
2b30da4
@ghazwan-gt
ghazwan-gt force-pushed the CCUBE-2188/fileupload branch from 33753ad to 2b30da4 Compare August 28, 2026 08:20
qroll
qroll reviewed Sep 9, 2026
View reviewed changes
Comment thread e2e/tests/components/file-upload/file-upload.e2e.spec.ts
Comment thread src/file-upload/file-list/file-list.tsx Outdated
Comment thread src/file-upload/file-list/file-list.tsx Outdated
Comment thread src/file-upload/file-list/file-list.tsx
qroll
qroll reviewed Sep 17, 2026
View reviewed changes
Comment thread src/file-upload/file-list-item/file-list-item.tsx Outdated
@qroll qroll added this to the v4.0.0-alpha.13 milestone Sep 18, 2026
@qroll
qroll merged commit daecfb6 into master Sep 18, 2026
11 of 12 checks passed
@qroll
qroll deleted the CCUBE-2188/fileupload branch September 18, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qroll qroll qroll approved these changes

Assignees

@ghazwan-gt ghazwan-gt

Labels

type: chore For technical improvements or refactoring. type: enhancement New feature or request

Projects

None yet

Milestone

v4.0.0-alpha.13

Development

Successfully merging this pull request may close these issues.

3 participants

@ghazwan-gt @qroll @ghazwanmuhammad