Trac#30220 do not remove hidden bookmarks in OOoBasedMailMerge#381
Closed
mistmist wants to merge 3 commits into
Closed
Trac#30220 do not remove hidden bookmarks in OOoBasedMailMerge#381mistmist wants to merge 3 commits into
mistmist wants to merge 3 commits into
Conversation
mistmist
commented
Jul 27, 2022
mistmist
commented
Contributor
- fix the bookmarks removal
- fix javadoc problems that were preventing the build from succeeding
As detected by openjdk version "11.0.15".
OOoBasedMailMerge.removeAllBookmarks(): Hidden bookmarks with conditions are required during mail merge as the condition often depends on the current data record. Apparently this function was added due to performance issues with a large number of data records in commit a1549bf - remains to be seen if this is still a problem.
Contributor
Author
|
Please see this other PR: #382 It's likely that this one here isn't actually the solution to the problem and the other PR should be merged. |
Contributor
|
Closing this (superseded by PR #382). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.